This repository was archived by the owner on Feb 22, 2022. It is now read-only.
Repository navigation
[stable/mariadb] fix upgrading existing statefulsets - #18704
Merged
Merged
Conversation
This was referenced Nov 8, 2019
alemorcuq
approved these changes
Nov 8, 2019
alemorcuq
suggested changes
Nov 8, 2019
alemorcuq
left a comment
Contributor
There was a problem hiding this comment.
Users with 6.13.0 and k8s < 1.16 won't be able to upgrade, right?
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec. In helm#17308 the `apiVersion` of the statefulset resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage. In this PR we have bumped the chart major version to signify this and also added the mariadb.statefulset.apiVersion` helper that returns the correct `apiVersion` to use depending on the k8s version Signed-off-by: Sameer Naik <sameersbn@vmware.com>
sameersbn
force-pushed
the
mariadb-upgrade-fix
branch
from
November 8, 2019 13:17
cc7eb5e to
c81b02a
Compare
Collaborator
|
Thanks so much for taking care of this @sameersbn ! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juan131, sameersbn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JoseAlban
pushed a commit
to JoseAlban/charts
that referenced
this pull request
Nov 22, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec. In helm#17308 the `apiVersion` of the statefulset resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage. In this PR we have bumped the chart major version to signify this and also added the mariadb.statefulset.apiVersion` helper that returns the correct `apiVersion` to use depending on the k8s version Signed-off-by: Sameer Naik <sameersbn@vmware.com>
hakman
pushed a commit
to hakman/charts
that referenced
this pull request
Dec 5, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec. In helm#17308 the `apiVersion` of the statefulset resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage. In this PR we have bumped the chart major version to signify this and also added the mariadb.statefulset.apiVersion` helper that returns the correct `apiVersion` to use depending on the k8s version Signed-off-by: Sameer Naik <sameersbn@vmware.com>
dargolith
pushed a commit
to dargolith/charts
that referenced
this pull request
Jan 10, 2020
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec. In helm#17308 the `apiVersion` of the statefulset resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage. In this PR we have bumped the chart major version to signify this and also added the mariadb.statefulset.apiVersion` helper that returns the correct `apiVersion` to use depending on the k8s version Signed-off-by: Sameer Naik <sameersbn@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.
In #17308 the
apiVersionof the statefulset resources was updated toapps/v1in tune with the api's deprecated, resulting in compatibility breakage.This major version bump signifies this change.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])