Migrate to oras-go library #9675
Conversation
| github.com/stretchr/testify v1.7.0 | ||
| github.com/xeipuuv/gojsonschema v1.2.0 | ||
| golang.org/x/crypto v0.0.0-20210220033148-5ea612d1eb83 | ||
| golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2 |
There was a problem hiding this comment.
Is there a way to prevent this update in this PR? I'm trying to figure out what's necessary for the name change vs. what should be pulled out into a separate PR. Changes to /x/crypto might be best as a separate review item if at all possible.
There was a problem hiding this comment.
I can't tell, this has been introduced by go mod tidy, so I assume required by transitive dependencies...
There was a problem hiding this comment.
@ndeloof I agree with @bacongobbler. Lets not change modules that are not part of the PR in question. Do you mind rolling this back?
There was a problem hiding this comment.
As I said, this update is forced by go mod, if I revert this it will be added again any time you run go mod xx commands.
There was a problem hiding this comment.
@ndeloof Looking further https://github.com/oras-project/oras-go/blob/main/go.mod is added in https://github.com/oras-project/oras-go/blob/main/go.mod, so probably picking it up from there.
There was a problem hiding this comment.
I am ok with the change to golang.org/x/crypto module as stated in #9675 (comment). LGTM. I will hold on merging as would like @bacongobbler to give his opinion on it.
| github.com/stretchr/testify v1.7.0 | ||
| github.com/xeipuuv/gojsonschema v1.2.0 | ||
| golang.org/x/crypto v0.0.0-20210220033148-5ea612d1eb83 | ||
| golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2 |
There was a problem hiding this comment.
@ndeloof Looking further https://github.com/oras-project/oras-go/blob/main/go.mod is added in https://github.com/oras-project/oras-go/blob/main/go.mod, so probably picking it up from there.
|
ping @bacongobbler, ptal 🙏 |
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
just rebased to fix go.sum conflict |
|
A heads up - this change causes an indirect import of k8s.io/kubernetes library which is generally pretty heavy. Opened containerd/containerd#5781 to track this |
see oras-project/oras#265
What this PR does / why we need it:
https://github.com/deislabs/oras has been rearchitectured to introduce oras-go library
This PR adopts this library
Special notes for your reviewer:
If applicable: