Skip to content

Conversation

@howardjohn
Copy link
Contributor

What this PR does / why we need it:
Updates oras-go. #9675 just added this dependency, but it was too an old version. Possibly because the name of the import changed

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2021
@bacongobbler
Copy link
Member

cc @jdolitsky

@zees-dev
Copy link

Any timeline on when this can get merged?

@zees-dev
Copy link

note: Im using the following workaround for now (until this is merged).

Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @jdolitsky must have missed this one, but I think it looks ready to go. So I am gonna mark it LGTM.

@technosophos
Copy link
Member

Oops... by LGTMing it, I triggered a conflict check I guess. This needs a quick rebase, and then it can be merged.

@ncopa
Copy link

ncopa commented Aug 19, 2021

This PR is needed for k0s to be able to use helm 3.6.1 to fix CVE-2021-32690. Using containerd 1.4 as workaround as suggest in #9970 (comment) does not work for us as it breaks windows build.

Signed-off-by: John Howard <howardjohn@google.com>
@howardjohn
Copy link
Contributor Author

Should be good to go now.

@bacongobbler bacongobbler merged commit bd62fb2 into helm:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants