Skip to content

Allow npm-publish with pnpm - #14

Merged
gndelia merged 1 commit into
mainfrom
allow-publish-pnpm
Jan 30, 2026
Merged

gndelia merged 1 commit into
mainfrom
allow-publish-pnpm

Conversation

@gndelia

@gndelia gndelia commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

This PR updates the npm-publish command to support pnpm for the installation step. Note that publishing remains the same, pnpm is only used to install dependencies/setup the project

@gndelia gndelia self-assigned this Jan 28, 2026
@gndelia
gndelia enabled auto-merge (squash) January 28, 2026 17:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for using pnpm as an alternative package manager in the npm-publish workflow. The change introduces a new optional input parameter package-manager that defaults to npm, allowing users to specify pnpm for dependency installation while maintaining the same publishing behavior.

Changes:

  • Added a new workflow input parameter package-manager with default value "npm"
  • Updated the setup-node-env action reference to a version that supports the package manager parameter
  • Added a comment clarifying that both npm and pnpm support the same CLI commands used in the workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@joshuasing joshuasing left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@gabmontes gabmontes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be using this repository for reusable workflows but hemilabs/actions.

@gndelia
gndelia merged commit e789193 into main Jan 30, 2026
2 checks passed
@gndelia
gndelia deleted the allow-publish-pnpm branch January 30, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants