Skip to content

Allow to query for server extensions available. - #591

Merged
hierynomus merged 1 commit into
hierynomus:masterfrom
iterate-ch:issue-590
Jun 5, 2020
Merged

Allow to query for server extensions available.#591
hierynomus merged 1 commit into
hierynomus:masterfrom
iterate-ch:issue-590

Conversation

@dkocher

@dkocher dkocher commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

Fix for #590.

@dkocher
dkocher requested a review from hierynomus as a code owner June 5, 2020 08:58
@hierynomus

Copy link
Copy Markdown
Owner

Shouldn't we also be checking the server extensions when doing extended requests?

@dkocher

dkocher commented Jun 5, 2020

Copy link
Copy Markdown
Contributor Author

Shouldn't we also be checking the server extensions when doing extended requests?

I think that should be the responsibility of the user. We use it like

if supportsServerExtension("statvfs", "openssh.com")
    newExtendedRequest("statvfs@openssh.com")

@hierynomus

Copy link
Copy Markdown
Owner

Shouldn't we also be checking the server extensions when doing extended requests?

I think that should be the responsibility of the user. We use it like

if supportsServerExtension("statvfs", "openssh.com")
    newExtendedRequest("statvfs@openssh.com")

It would actually be good to guard against sending bad requests to the server, as we know which extended requests are available. I'll add that in a separate PR and merge this one, as it is a pre-existing situation.

@hierynomus
hierynomus merged commit 2d8af5a into hierynomus:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants