MM-011 resolve boundsless semantic selectors - #4
Draft
himattm wants to merge 1 commit into
Draft
Conversation
Reproduction: content-desc=Debug tools matched a boundsless Compose semantics record while the adjacent clickable record at 815,240 had valid geometry, so Minimap returned action_failed. Rank related actionable nodes by ancestry, shared identity and flat-list proximity, or overlapping geometry; preserve semantic selectors in recorded edges and include bounded node diagnostics only when no tappable relation exists. Verified with the captured Debug tools CLI contract, shared-key, ancestor, overlap, and diagnostic unit tests, cargo test --workspace, cargo clippy --all-targets -- -D warnings, cargo fmt --check, and the minimap-cli binary build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Resolve accessibility selectors through related actionable nodes when the matching semantics node has no geometry. The resolver now considers actionable ancestors and descendants, shared identity with flat-layout proximity, overlapping geometry, multiple Android bounds encodings, and bounded diagnostics.
Why
Real Compose output can place a stable
content-descon a boundsless semantics record while the adjacent clickable record owns the tap center. Minimap stopped at the label node and returnedmatched node has no tap bounds.Impact
Stable accessibility labels can drive taps without falling back to brittle coordinates, while truly unresolved selectors still return diagnostics naming the related nodes considered.
Validation
Stack
Depends on #3; base branch:
agent/mm-002-no-device-error.