Check for manifest in versioned rocks trees first#11
Merged
hishamhm merged 1 commit intohishamhm:masterfrom Jun 12, 2015
Merged
Check for manifest in versioned rocks trees first#11hishamhm merged 1 commit intohishamhm:masterfrom
hishamhm merged 1 commit intohishamhm:masterfrom
Conversation
When a versioned rocks tree and a non-versioned rocks tree coexist, prefer the versioned one. * On a machine with a single rocks tree, versioned or no, this has no effect. * On a machine with both, and the unversioned tree points to the right lua version, this has no effect. * But on a machine where the unversioned tree points to another version of lua, the right manifest file will be read instead of the wrong one.
hishamhm
added a commit
that referenced
this pull request
Jun 12, 2015
Check for manifest in versioned rocks trees first
Owner
|
Good catch! Thank you!! |
Owner
|
I uploaded version 0.2 to luarocks.org, including this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a versioned rocks tree and a non-versioned rocks tree coexist, prefer the versioned one.
lua version, this has no effect.
of lua, the right manifest file will be read instead of the wrong one.
This patch resolves a problem I posted to the mailing list where datafile wasn't generating the paths needed to find my luarocks-installed templates: Since luarocks installed them to a directory with my package version in it, datafile would have needed the correct manifest to find it, and since it was actually finding a manifest, just not the right one, it gave no outward error.