This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Open
Conversation
This closes issue hishamhm#930.
Collaborator
|
Merged here: htop-dev/htop@fed14a5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest the following small fix with the following reasoning:
amtReadin functionLinuxProcessList_readCmdlineFileare meant to protect the execution of the for loop (and what follows it), which is not supposed to be run withamtRead == 0(if I understand correctly),LinuxProcessList_recurseProcTreeat line 883 after the "offending" call toLinuxProcessList_readCmdlineFileat line 856.To me this is a quick fix and the setting of command name of processes seems a little bit clumsy (i.e.
readCmdlineFileis not just reading, but actually setting the command name of a process and classifying it as a kernel thread), however, I lack the insight as well as experience to write it better. Maybe setting the command name of a zombie process should also be moved toreadCmdlineFileand the function renamed. Please, let me know what you think about it.This closes issue #930.