This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Open
Conversation
aswild
pushed a commit
to aswild/htop
that referenced
this pull request
Apr 9, 2020
Switch Travis to catch GCC 10 issues Squashed cherry-pick of hishamhm#981
aswild
added a commit
to aswild/htop
that referenced
this pull request
Apr 9, 2020
Follow-up to cherry-picking hishamhm#981 * add -fno-common to AM_CFLAGS * move -D and -I options from AM_CFLAGS to AM_CPPFLAGS
Collaborator
|
See line 1 of CRT.h and linux/LinuxProcess.h :
|
lpereira
pushed a commit
to lpereira/htop
that referenced
this pull request
Aug 9, 2020
Extends the MakeHeader script to auto-generate correct "extern" function declarations in some cases that it currently does not. Related to hishamhm#981
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @hishamhm
GCC 10 switches from
-fcommonto-fno-commonby default (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85678), and htop currently fails when building against-fno-common.I've enabled
-fno-commonin Travis to emulate GCC 10's behaviour, to catch any future bugs like this.