Example bad PR: modifies kong/conf_loader.lua without kong.conf.default#3
Open
Example bad PR: modifies kong/conf_loader.lua without kong.conf.default#3
Conversation
… kong.conf.default Since tests run with the conf loader in strict mode, any addition of directives (or changes to directive enums) requires a change to kong/conf_loader.lua. In this test, we verify that a PR including a change to this file also includes a change to kong.conf.default. When a change to kong.conf_loader does _not_ require a change in kong.conf.default (for example, when performing an internal refactor), this test can be silenced by adding the hashtag #noconfchange to the commit message. This is still a approximation (an even stricter test would require kong.conf.default to be changed in the same commit), but it should be sufficient to require all new configuration entries added via pull requests to be documented.
6d793a4 to
5b414a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.