Skip to content

Add timetable source disclaimer - #312

Open
evnchn wants to merge 2 commits into
hkbus:masterfrom
evnchn:feat/timetable-source-disclaimer
Open

evnchn wants to merge 2 commits into
hkbus:masterfrom
evnchn:feat/timetable-source-disclaimer

Conversation

@evnchn

@evnchn evnchn commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

When an operator changes a route, the government open-data timetable can lag behind, leaving the app's timetable stale or absent with no signal to the user. Two live cases in August 2026 (CTB 770 broken 18 days; CTB 50M inbound still unmatched).

A community member proposed a disclaimer next to the operator link; this PR adds it. +14/−0, two files: a caption below the operator-link button, plus en/zh translation keys.

en: "Timetable data from the government open-data platform may lag behind operator changes. For the latest timetable, please check the operator's or Transport Department's website."

Government open-data timetables lag operator route changes by roughly
two weeks, and users read the lag as an app bug. Adds a short
disclaimer under the operator-website button in the timetable drawer,
in both languages, so the gap is explained in place rather than
generating repeat "please update route X" reports.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 66f9cdb8-7c32-4e18-83e3-cad49e7a5a21

📥 Commits

Reviewing files that changed from the base of the PR and between d383c0c and 5ed33a5.

📒 Files selected for processing (1)
  • src/i18n/translation.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/i18n/translation.js

📝 Walkthrough

Walkthrough

The timetable drawer now shows a localized disclaimer below the official route URL button. English and Traditional Chinese translations explain that government timetable data may lag operator updates.

Changes

Timetable disclaimer

Layer / File(s) Summary
Localized timetable disclaimer
src/i18n/translation.js, src/components/route-eta/timetableDrawer/TimeTable.tsx
The timetable drawer renders English and Traditional Chinese disclaimer text with secondary caption styling and top spacing.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to 5ed33

This adds a localized timetable disclaimer and translations without changing timetable data, routing, permissions, or runtime dependencies; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a timetable source disclaimer.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@evnchn

evnchn commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author
image

Lack the margin is not this PR issue, pre-existing

@youareveryfar

Copy link
Copy Markdown
Contributor
image

Lack the margin is not this PR issue, pre-existing

For 專線小巴 aka GMB routes, usually there is no operator's website available.
Better to say "營辦商或運輸署網頁" instead of "巴士公司網頁" in Chinese and "the operator's or Transport Department's website" instead of "the operator's website" in English.

GMB routes usually have no operator website, so the disclaimer now
also points to the Transport Department's site.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@evnchn

evnchn commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Done as you said — pushed 5ed33a5.

@evnchn
evnchn changed the base branch from master to alpha-release August 14, 2026 04:13
@evnchn
evnchn changed the base branch from alpha-release to master August 29, 2026 04:24
@evnchn evnchn changed the title Add timetable source disclaimer below operator link Add timetable source disclaimer Aug 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants