Repository navigation
1.50: include directive's globs break when journal files are underneath a dotted directory #2498
Description
What I initially observed:
Success:
~> /usr/local/bin/hledger --version; /usr/local/bin/hledger check
hledger 1.43.2, linux-x86_64
Fail:
~> /usr/bin/hledger --version; /usr/bin/hledger check
hledger 1.50.3, linux-x86_64
hledger: Error: /home/[redacted]/.local/share/hledger/all.journal:1:1:
|
1 | include global/*.journal
| ^
No files were matched by glob pattern: global/*.journal
Old globs:
~> /usr/bin/hledger --version; /usr/bin/hledger check --old-glob
hledger 1.50.3, linux-x86_64
My journals are located under ~/.local, so this appears to be fallout from the exclusion of dotted directories from glob results. Presumably this change was only meant to prevent traversing dotted directories in the glob expansion, not to break any globs that happened to get evaluated entirely underneath a dotted directory.
Activity
[-]hledger 1.50 no longer resolves glob patterns in journal includes[/-][+]hledger 1.50 globs break when the journal files are underneath a dotted directory[/+]simonmichael commentedon Nov 20, 2025
You're right, this is bigger fallout from the new glob implementation than was expected or documented. Darn! Thanks for the report @psagers. You've earned the https://hledger.org/REGRESSIONS.html#regression-finder-bounty (please claim within 7 days).
simonmichael commentedon Nov 20, 2025
PS to work around, add --old-glob to your ~/.hledger.conf for now.
[-]hledger 1.50 globs break when the journal files are underneath a dotted directory[/-][+]1.50: include directive's globs break when journal files are underneath a dotted directory[/+]psagers commentedon Nov 24, 2025
Just happy to contribute. Fortunately, it's easy to work around.
simonmichael commentedon Dec 4, 2025
I think the right thing to do here is
roll back this 1.50 change:
and release 1.50.4 to stabilise the 1.50 series, with the --old-glob flag ignored
and drop the --old-glob flag in 1.51.
This will restore the old pre-1.50 behaviour (of
**with respect to dot things): 1.50's complete exclusion of dot paths will be dropped, and**will once again implicitly search non-top-level dot directories.This means
**will once again search things like a non-top-level .git directory, but (a) no-one has ever complained about this and (b) if it ever causes a problem that should be easy to work around by making the glob pattern more specific, eg saying**.journalinstead of**.fix:journal:include: drop 1.50's exclusion of glob-matched dot paths [#…
fix:journal:include: drop 1.50's exclusion of glob-matched dot paths [#…