Skip to content

Improve project health checks and runtime safety #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmmhmmhm merged 8 commits into from
Jul 25, 2026
Merged

Improve project health checks and runtime safety #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1bb7697
docs: design project health improvements
hmmhmmhm Jul 25, 2026
fb791ba
docs: plan project health improvements
hmmhmmhm Jul 25, 2026
14ac268
fix: ignore stale session refreshes
hmmhmmhm Jul 25, 2026
731133c
fix: cancel tmux work with the UI
hmmhmmhm Jul 25, 2026
af84497
ci: enforce source file line limit
hmmhmmhm Jul 25, 2026
5ce6484
test: exercise the compiled tab binary
hmmhmmhm Jul 25, 2026
964f0d1
ci: expand project quality checks
hmmhmmhm Jul 25, 2026
4e9aa52
test: exclude generated source from line checks
hmmhmmhm Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,26 @@ jobs:
exit 1
}

quality:
name: Quality (Ubuntu)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
- uses: actions/setup-go@v7
with:
go-version-file: go.mod
cache-dependency-path: go.sum
- name: Verify source file line limit
run: sh scripts/check-source-lines.sh
- name: Test source file line checker
run: sh scripts/test-source-lines.sh
- name: Check Go vulnerabilities
run: go run golang.org/x/vuln/cmd/govulncheck@v1.6.0 ./...
- name: Check shell scripts
run: shellcheck install.sh scripts/*.sh
- name: Check GitHub Actions workflows
run: go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12

integration:
name: Integration (Ubuntu)
runs-on: ubuntu-latest
Expand All @@ -65,5 +85,7 @@ jobs:
run: go test -race ./...
- name: Installer tests
run: sh scripts/test-install.sh
- name: tab binary smoke test
run: sh scripts/tab-binary-smoke.sh
- name: tmux smoke test
run: sh scripts/tmux-smoke.sh
2 changes: 1 addition & 1 deletion .github/workflows/dependency-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
- uses: actions/dependency-review-action@v4
- uses: actions/dependency-review-action@a1d282b36b6f3519aa1f3fc636f609c47dddb294 # v5.0.0
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,23 @@ go test ./...

Write a failing test before changing behavior. Keep tmux command execution in `internal/tmux`, Bubble Tea state in `internal/ui`, and CLI orchestration in `internal/app`.

Keep every tracked, hand-written `.go`, `.sh`, `.ps1`, `.yml`, and `.yaml` file at or below 450 lines. This includes tests and workflow configuration. Documentation, `dist`, vendored code, Go files with the standard `Code generated ... DO NOT EDIT.` header, and binary assets are excluded. Split a file by responsibility before it exceeds the limit.

Run all checks before opening a pull request:

```sh
test -z "$(gofmt -l .)"
go vet ./...
go test -race ./...
go build ./cmd/tab
sh scripts/check-source-lines.sh
sh scripts/test-source-lines.sh
sh scripts/test-install.sh
sh scripts/tmux-smoke.sh
sh scripts/tab-binary-smoke.sh
go run golang.org/x/vuln/cmd/govulncheck@v1.6.0 ./...
go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12
shellcheck install.sh scripts/*.sh
```

Pull requests should be small, explain user-visible behavior, and include tests. Do not include generated `dist` artifacts.
Expand Down
Loading