Skip to content

Fix generator bypass of sculpt review gates#8

Open
ahmadalzaro1 wants to merge 1 commit into
hoainho:mainfrom
ahmadalzaro1:fix/unify-review-pass-gates
Open

Fix generator bypass of sculpt review gates#8
ahmadalzaro1 wants to merge 1 commit into
hoainho:mainfrom
ahmadalzaro1:fix/unify-review-pass-gates

Conversation

@ahmadalzaro1

Copy link
Copy Markdown

Summary

  • make generate_threejs_factory.py use the orchestrator's authoritative review-completion gate
  • prevent manually edited screenshot-only review history from unlocking later sculpt passes
  • keep valid, fully reviewed passes unlockable and update the lock guidance to mention the required visual comparison evidence

Problem

The generator had a weaker local copy of review_completes_pass. A manually edited review entry with action=continue and only visualEvidence.renderScreenshot could unlock the next pass, even though sculpt_pass_orchestrator.py correctly rejected the same entry because it lacked a comparison image, an accepted AI vision score, and passing critical feature reviews.

Verification

  • Added a regression test and confirmed it failed before the fix because the generator returned exit code 0.
  • Confirmed the regression test passes after delegating to the orchestrator gate.
  • Confirmed a valid review created through append_sculpt_review.py still unlocks structural-pass generation.
  • python3 -m unittest discover -s scripts/tests -v — 20 tests passed.
  • ruff check scripts/generate_threejs_factory.py scripts/tests/test_pipeline.py — passed.
  • python3 -m compileall -q scripts — passed.
  • git diff --check — passed.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors generate_threejs_factory.py by delegating the pass completion check to sculpt_pass_orchestrator.review_completes_pass instead of maintaining a local duplicate implementation. It also updates the error message for locked passes to mention visual comparison evidence and adds integration tests in test_pipeline.py to verify that factory generation correctly respects complete and incomplete manual review evidence. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant