Fix generator bypass of sculpt review gates#8
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors generate_threejs_factory.py by delegating the pass completion check to sculpt_pass_orchestrator.review_completes_pass instead of maintaining a local duplicate implementation. It also updates the error message for locked passes to mention visual comparison evidence and adds integration tests in test_pipeline.py to verify that factory generation correctly respects complete and incomplete manual review evidence. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
generate_threejs_factory.pyuse the orchestrator's authoritative review-completion gateProblem
The generator had a weaker local copy of
review_completes_pass. A manually edited review entry withaction=continueand onlyvisualEvidence.renderScreenshotcould unlock the next pass, even thoughsculpt_pass_orchestrator.pycorrectly rejected the same entry because it lacked a comparison image, an accepted AI vision score, and passing critical feature reviews.Verification
append_sculpt_review.pystill unlocksstructural-passgeneration.python3 -m unittest discover -s scripts/tests -v— 20 tests passed.ruff check scripts/generate_threejs_factory.py scripts/tests/test_pipeline.py— passed.python3 -m compileall -q scripts— passed.git diff --check— passed.