Skip to content

Add SafeSkill security badge (50/100 — Use with Caution)#10

Closed
OyaAIProd wants to merge 1 commit into
hoainho:mainfrom
OyaAIProd:safeskill-scan-1779329409307
Closed

Add SafeSkill security badge (50/100 — Use with Caution)#10
OyaAIProd wants to merge 1 commit into
hoainho:mainfrom
OyaAIProd:safeskill-scan-1779329409307

Conversation

@OyaAIProd

Copy link
Copy Markdown

🟠 SafeSkill Security Scan Results

Metric Value
Overall Score 50/100 (Use with Caution)
Code Score 58/100
Content Score 64/100
Findings 403 findings detected (26 critical)
Taint Flows 2
Files Scanned 219
Scan Duration 11.7s

Top Findings

  • 🔴 critical: Spawns child process (apps/extension-chrome/src/background.ts:788)
  • 🔴 critical: Imports child_process module (apps/ide-vscode/extension-out/extension.js:39)
  • 🔴 critical: Imports child_process module (apps/ide-vscode/src/extension.ts:1)
  • 🔴 critical: Spawns child process (apps/ide-vscode/src/extension.ts:32)
  • 🔴 critical: Spawns child process (packages/core/src/sourcemap-resolver.ts:11)

View full report on SafeSkill


About SafeSkill

SafeSkill is a free, open-source security scanner for AI tools, MCP servers, and Claude Code skills. We scan for code exploits, prompt injection, and data exfiltration risks.

False positive? We take accuracy seriously. If any finding above is incorrect, please open an issue and we will fix it immediately.

Signed-off-by: SafeSkill Scanner <mk@oya.ai>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a SafeSkill security badge to the README.md file. The review feedback points out that the badge currently displays a 'Use with Caution' warning and a score of 50/100, which could negatively impact user trust. It is recommended to triage the scanner's findings or configure it to ignore expected behaviors before including the badge in the documentation.

Comment thread README.md
[![MCP](https://img.shields.io/badge/MCP-compatible-7c3aed)](https://modelcontextprotocol.io)
[![Chromium](https://img.shields.io/badge/real--browser-Chromium-4285f4)](https://www.chromium.org/)
[![License](https://img.shields.io/badge/license-Apache--2.0-blue)](./LICENSE)
[![SafeSkill 50/100](https://img.shields.io/badge/SafeSkill-50%2F100_Use%20with%20Caution-orange)](https://safeskill.dev/scan/hoainho-ohmyperf)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The security badge displays a 'Use with Caution' warning and a score of 50/100. The findings mentioned in the PR description, such as spawning child processes, appear to be expected behaviors for a performance tool and browser extension. Adding this badge without triaging these as false positives or explaining the context may negatively impact user trust. It is recommended to address these findings or configure the scanner to ignore expected behaviors before including the badge in the README.

@hoainho

hoainho commented May 21, 2026

Copy link
Copy Markdown
Owner

Thanks for the scan, but closing this — not merging.

Why:

  1. The proposed badge would damage first-impression conversion on a public repo currently in early 0→100-star growth mode. "50/100 — Use with Caution" on a real-Chromium browser-automation + MCP tool reads as scary to a developer scanning the README in 3 seconds. We're optimizing the README hero specifically for that audience right now.

  2. The five critical findings are true-positive pattern matches but false-positive security concerns in the context of what OhMyPerf does:

    All three are documented capabilities a Chromium-driving perf tool requires by design. Flagging them as critical without considering the project's category (browser-automation runtime) generates noise, not signal.

  3. No supply-chain audit, no taint-analysis explanation. A real security report on a project of this shape would weigh the actual attack surface (the npx -y @ohmyperf/cli install path, the published npm-scoped packages, the MCP server's tool surface) — none of which the scan addresses. The score reflects pattern frequency, not threat model.

If anh wants a security audit, em sẽ run our own (issue welcome). If SafeSkill the project wants to land on this repo organically, the path is: contribute a real finding (file an issue with a specific exploit chain), not auto-PR a marketing badge.

For now: closing + deleting the branch.

Em không có ill will toward SafeSkill — automated scans on public repos are fine — em chỉ không merge link-spam disguised as security signal on a repo trying to convert first-time visitors.

cc @NHONH

@hoainho hoainho closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants