Ensure we only de-duplicate param value events - #8436
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8436 +/- ##
==========================================
- Coverage 86.10% 85.42% -0.68%
==========================================
Files 349 349
Lines 54847 54850 +3
==========================================
- Hits 47225 46855 -370
- Misses 7622 7995 +373 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philippjfr
commented
Feb 24, 2026
philippjfr
commented
Feb 24, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
Parampane tracks parameter events and blocks events from bouncing back and forth by tracking when a parameter value is changing. However we track this for all parameter attribute changes, including attributes like constant, label etc., and treat all of these the same. This means that when constant is toggled it can occur that we end up dropping events for another attribute or even the value. We now only apply this handling when the value changes.