Ensure ESM model definition can be loaded dynamically - #8432
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8432 +/- ##
==========================================
- Coverage 86.11% 86.11% -0.01%
==========================================
Files 349 349
Lines 54841 54847 +6
==========================================
+ Hits 47227 47229 +2
- Misses 7614 7618 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 2, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an ESM model is imported for the first time while an app is already running the bokeh
DataModeldefinition, which is usually included in the serializedDocumenton page load, will not be initialized. This leads to an inscrutable error saying that the Model could not be resolved on the frontend. Here we introduce a flag on the class definition that indicates whether the model is initialized by checking whether we are in a server context when theReactiveESMclass is defined. If so we include the definition on theReactiveESMmodel that holds the DataModel instance and by declaring it on a property with a trailing underscore (_defs) we ensure the model definition is unserialized before the instance of that model is deserialized.