Skip to content

enh: validate all next_url and error if not valid - #8575

Merged
philippjfr merged 2 commits into
mainfrom
enh_validate_next_url
May 5, 2026
Merged

philippjfr merged 2 commits into
mainfrom
enh_validate_next_url

Conversation

@hoxbro

@hoxbro hoxbro commented May 5, 2026

Copy link
Copy Markdown
Member

Description

Validate all occurrences of next_url. I have chosen to raise an HTTPError instead of cleaning up the URL, but are open to reverting it if needed.

How Has This Been Tested?

CI

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested all AI-generated content in my PR.
    • I take responsibility for all AI-generated content in my PR.

Tools and Models: Claude Code + Sonnet 4.6

Checklist

  • Tests added and are passing

@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.07%. Comparing base (9a51f67) to head (ed4e6f8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
panel/auth.py 6.66% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8575      +/-   ##
==========================================
+ Coverage   85.04%   85.07%   +0.02%     
==========================================
  Files         350      350              
  Lines       56018    56017       -1     
==========================================
+ Hits        47642    47655      +13     
+ Misses       8376     8362      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr
philippjfr merged commit a6a8b2c into main May 5, 2026
16 of 18 checks passed
@philippjfr
philippjfr deleted the enh_validate_next_url branch May 5, 2026 14:07
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants