Skip to content

Remove neato integration #154902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

Remove neato integration #154902

merged 2 commits into from
Oct 29, 2025

Conversation

@mib1185
Copy link
Member

@mib1185 mib1185 commented Oct 20, 2025 •
edited by edenhaus
Loading

Breaking change

Vorwerk announced the shutdown of all neato cloud services. Because of this shutdown, the integration will no longer be able to control any neato devices, thus becoming dis-functional.

Proposed change

SSIA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@mib1185 mib1185 added this to the 2025.11.0b0 milestone Oct 20, 2025
Copilot AI review requested due to automatic review settings October 20, 2025 20:20
@mib1185 mib1185 requested a review from a team as a code owner October 20, 2025 20:20
@mib1185 mib1185 requested a review from joostlek as a code owner October 20, 2025 20:20
@home-assistant
Copy link

home-assistant bot commented Oct 20, 2025

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (analytics_insights) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of analytics_insights can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign analytics_insights Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Oct 20, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant_alerts) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant_alerts can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant_alerts Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copilot AI reviewed Oct 20, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the Neato integration from Home Assistant due to Vorwerk's announcement that all Neato cloud services will be shut down, making the integration non-functional.

Key Changes

  • Complete removal of the Neato integration and all related components
  • Removal of test fixtures and test files for Neato
  • Cleanup of references to Neato in quality scale rules, strict typing configuration, and analytics data

Reviewed Changes

Copilot reviewed 27 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
homeassistant/components/neato/* All integration source files removed (main init, platforms, config flow, API, entities, constants)
tests/components/neato/* All test files for the integration removed
tests/components/homeassistant_alerts/* Removed Neato from alert test fixtures and test expectations
tests/components/analytics_insights/fixtures/current_data.json Removed Neato usage statistics
requirements_all.txt Removed pybotvac dependency
requirements_test_all.txt Removed pybotvac test dependency
mypy.ini Removed Neato mypy configuration
.strict-typing Removed Neato from strict typing list
script/hassfest/quality_scale.py Removed Neato from quality scale exempt lists

@mib1185 mib1185 mentioned this pull request Oct 20, 2025
Merged
8 tasks
@tr4nt0r
Copy link
Contributor

tr4nt0r commented Oct 20, 2025

I haven't read of a fixed deadline in the announcement. Afaik it is still online, maybe we should wait until it is actually shut down?

@pantherale0
Copy link
Contributor

pantherale0 commented Oct 21, 2025

FYI - Still 700+ installations with this integration according to the analytics.

@mib1185
Copy link
Member Author

mib1185 commented Oct 21, 2025

we should wait until we really know that the integration is not working anymore

@mib1185 mib1185 marked this pull request as draft October 21, 2025 14:51
@thecode
Copy link
Member

thecode commented Oct 21, 2025

I haven't read of a fixed deadline in the announcement. Afaik it is still online, maybe we should wait until it is actually shut down?

I tested the following URLs yesterday which are used by the upstream package to connect to Neato cloud:
https://github.com/stianaske/pybotvac/blob/7a5b373d158934a766006913c16bb81f32356398/pybotvac/neato.py#L23-L25

Yesterday they didn't even resolve but this may be related to AWS incident, however even today while they resolve to AWS the cloud service they point to is down.

FYI - Still 700+ installations with this integration according to the analytics.

AFAIK analytics is broken and was not updated for few months

@tr4nt0r
Copy link
Contributor

tr4nt0r commented Oct 21, 2025

@thecode was broken. Today there are 731 users still (yesterday 764)

@mib1185
Copy link
Member Author

mib1185 commented Oct 28, 2025

We've meanwhile multiple users confirming, that the integration stopped working, so I think we can proceed with removing it?

@mib1185 mib1185 marked this pull request as ready for review October 28, 2025 21:51
@edenhaus
Copy link
Member

edenhaus commented Oct 29, 2025

Remove "upcoming" from the breaking change section as it looks like they already shut it down.

@edenhaus
Copy link
Member

edenhaus commented Oct 29, 2025

test failure unrelated

@edenhaus edenhaus merged commit a6c1ce8 into home-assistant:dev Oct 29, 2025
118 of 120 checks passed
@mib1185 mib1185 deleted the neato/remove-integration branch October 29, 2025 13:19
@Robbe-B
Copy link

Robbe-B commented Oct 30, 2025 •
edited
Loading

This integration still works perfectly atm. Why removing it early ?
image

@bertel2020
Copy link

bertel2020 commented Oct 31, 2025

Same here, still working

@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2025
@mib1185
Copy link
Member Author

mib1185 commented Nov 2, 2025

The integration will be re-added for now (#155685). The removal of it will be re-considered later, based on the analytics and possible user feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@thecode thecode thecode approved these changes

@joostlek joostlek Awaiting requested review from joostlek joostlek is a code owner

Assignees

@joostlek joostlek

Labels

breaking-change cla-signed Hacktoberfest has-tests integration: analytics_insights integration: homeassistant_alerts integration: neato Quality Scale: internal Quality Scale: No score remove-platform small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

2025.11.0b0

Development

Successfully merging this pull request may close these issues.

Neato cloud is about to be disabled

8 participants

@mib1185 @tr4nt0r @pantherale0 @thecode @edenhaus @Robbe-B @bertel2020 @joostlek