Skip to content

Revert "Remove neato integration (#154902)" #155685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2025
Merged

Revert "Remove neato integration (#154902)" #155685

merged 1 commit into from
Nov 2, 2025

Conversation

@mib1185
Copy link
Member

@mib1185 mib1185 commented Nov 2, 2025 •
edited
Loading

Proposed change

There are still some users reporting this integration as functional (see #154902 (comment)), so we discussed and decided to keep the integration for now and re-consider the removal later.

This reverts commit a6c1ce8.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@mib1185 mib1185 added this to the 2025.11.0 milestone Nov 2, 2025
Copilot AI review requested due to automatic review settings November 2, 2025 18:27
@mib1185 mib1185 requested review from a team and joostlek as code owners November 2, 2025 18:27
home-assistant[bot]
home-assistant bot previously requested changes Nov 2, 2025
View reviewed changes
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding new integrations, limit included platforms to a single platform. Please reduce this PR to a single platform

@home-assistant
Copy link

home-assistant bot commented Nov 2, 2025

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (analytics_insights) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of analytics_insights can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign analytics_insights Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Nov 2, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant_alerts) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant_alerts can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant_alerts Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant home-assistant bot marked this pull request as draft November 2, 2025 18:27
@home-assistant
Copy link

home-assistant bot commented Nov 2, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@mib1185 mib1185 mentioned this pull request Nov 2, 2025
Merged
8 tasks
@mib1185 mib1185 marked this pull request as ready for review November 2, 2025 18:28
@mib1185 mib1185 mentioned this pull request Nov 2, 2025
Merged
21 tasks
Copilot AI reviewed Nov 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Neato Botvac vacuum cleaner integration to Home Assistant, implementing OAuth2-based authentication to support newer Neato devices that require this method. The integration provides comprehensive control and monitoring of Neato robot vacuums including cleaning operations, scheduling, battery monitoring, and map visualization.

  • Implements OAuth2 authentication flow with application credentials support
  • Adds config flow with reauthentication support for migration from old authentication
  • Provides multiple platforms: vacuum, sensor, switch, camera, and button entities

Reviewed Changes

Copilot reviewed 27 out of 30 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
homeassistant/components/neato/__init__.py Integration entry point with setup/unload logic
homeassistant/components/neato/config_flow.py OAuth2 config flow with reauth support
homeassistant/components/neato/api.py OAuth2 session implementation
homeassistant/components/neato/application_credentials.py Application credentials platform
homeassistant/components/neato/hub.py Central hub for managing robot data
homeassistant/components/neato/entity.py Base entity class
homeassistant/components/neato/vacuum.py Vacuum platform with custom cleaning service
homeassistant/components/neato/sensor.py Battery sensor entity
homeassistant/components/neato/switch.py Schedule switch entity
homeassistant/components/neato/camera.py Cleaning map camera entity
homeassistant/components/neato/button.py Dismiss alert button entity
homeassistant/components/neato/const.py Domain constants and mappings
homeassistant/components/neato/strings.json Translations for UI
homeassistant/components/neato/services.yaml Service definitions
homeassistant/components/neato/icons.json Service icon mappings
homeassistant/components/neato/manifest.json Integration metadata
tests/components/neato/test_config_flow.py Config flow tests
Various test fixtures and config files Updates for alerts and analytics data
Comments suppressed due to low confidence (1)

homeassistant/components/neato/const.py:1

  • The constant BATTERY is defined but never used in the codebase. It should be removed to reduce clutter.
"""Constants for Neato integration."""

@joostlek joostlek merged commit 1badfe3 into home-assistant:dev Nov 2, 2025
72 of 73 checks passed
@mib1185 mib1185 deleted the revert-removal-of-neato branch November 3, 2025 07:03
bramkragten pushed a commit that referenced this pull request Nov 3, 2025
@mib1185 @bramkragten
Revert "Remove neato integration (#154902)" (#155685)
7e75ca7
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@thecode thecode thecode approved these changes

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

@joostlek joostlek Awaiting requested review from joostlek joostlek is a code owner

Assignees

@joostlek joostlek

Labels

bugfix cherry-picked cla-signed has-tests integration: analytics_insights integration: homeassistant_alerts integration: neato new-integration Quality Scale: internal Quality Scale: No score

Projects

None yet

Milestone

2025.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mib1185 @thecode @bramkragten @joostlek