Fix multiline context showing file start and end - #709
Open
vulragrag-star wants to merge 1 commit into
Open
vulragrag-star wants to merge 1 commit into
vulragrag-star wants to merge 1 commit into
Conversation
`--multi-line-context-lines` is meant to keep context around each change. For leading and trailing equal hunks it also printed the beginning and end of the multiline value. Only keep the context adjacent to actual inserts/deletes; equal hunks between changes still show both ends with the unchanged summary. Fixes homeport#686
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--multi-line-context-linesis meant to keep context around each change in a multiline value. For leading and trailing equal hunks it also printed the beginning and end of the file.Only keep the context adjacent to actual inserts/deletes. Equal hunks between changes still show both ends with the unchanged summary.
Example with
--multi-line-context-lines 2:Before:
After:
Fixes #686
Test plan
go test ./...--multi-line-context-linesadds unneeded beginning and end of file #686 inpkg/dyff(assets underassets/issues/issue-686/)dyff between from.yml to.yml --output github --multi-line-context-lines 2 --omit-header