Skip to content

Include full stack traces on Winston JSONL logs - #743

Merged
0x2b3bfa0 merged 1 commit into
masterfrom
full-stack-trace-json
Sep 23, 2021
Merged

0x2b3bfa0 merged 1 commit into
masterfrom
full-stack-trace-json

Conversation

@0x2b3bfa0

@0x2b3bfa0 0x2b3bfa0 commented Sep 23, 2021

Copy link
Copy Markdown
Member

Before

{"level":"error"}

After

{"level":"error","message":"terraform version\n\t\n\t/bin/sh: 1: terraform: not found\n","stack":"Error: terraform version\n\t\n\t/bin/sh: 1: terraform: not found\n\n    at /workspaces/cml/src/utils.js:15:27\n    at ChildProcess.exithandler (child_process.js:397:5)\n    at ChildProcess.emit (events.js:400:28)\n    at maybeClose (internal/child_process.js:1055:16)\n    at Socket.<anonymous> (internal/child_process.js:441:11)\n    at Socket.emit (events.js:400:28)\n    at Pipe.<anonymous> (net.js:675:12)"}

@0x2b3bfa0
0x2b3bfa0 temporarily deployed to internal September 23, 2021 10:41 Inactive
@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 23, 2021
@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working p0-critical Max priority (ASAP) labels Sep 23, 2021
@0x2b3bfa0 0x2b3bfa0 linked an issue Sep 23, 2021 that may be closed by this pull request

@DavidGOrtega DavidGOrtega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@0x2b3bfa0
0x2b3bfa0 merged commit 8d761bf into master Sep 23, 2021
@0x2b3bfa0
0x2b3bfa0 deleted the full-stack-trace-json branch September 23, 2021 10:46

This branch was previously deployed

1 inactive deployment
internal 0e9704c0 Deployed Sep 23, 2021 by 0x2b3bfa0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working p0-critical Max priority (ASAP)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Winston does not display error information on non–TTY contexts

3 participants