Conversation
iutzeler
commented
Nov 28, 2024
Owner
- Improved importance sampling
- Clarabel is the default solver for cvxpy instead of ECOS
- Multiclass classification now supported
Removed by defaulty, but can be launched through `make lfstests`
[TEST] Remove LFS-needing tests from test suite
[FIX] Fixed the default value of the erm mode
Just in case
Add up to 5 reruns for all misc tests
trailing space
Put the inverse lam scaling for the importance scaling in the normalizing function(s). That way None/float operations are avoided and mypy stops yelling.
The Covenant one seems great, if needed we shall change it later.
[ADD] Code of conduct
FIX: Let Dirac code abide to Liskov substitution principle
Instead of cast+flatten Minor style corrections
Feature/multiclass logistic
* [FIX] Switch to default solver (Clarabel)w/ CVXOPT Instead of ECOS, which is not shipped anymore * [FIX] Forgot Portfolio ECOS deprec
iutzeler
added a commit
that referenced
this pull request
Nov 28, 2024
* [TEST] Remove LFS-needing tests from test suite Removed by defaulty, but can be launched through `make lfstests` * [FIX] Fixed the default value of the erm mode * [FIX] Up to 5 reruns for all misc tests Just in case * Remove lbd from AD graph in IS * Add warning comment * Remove unecessary changes * [STYLE] Update _impsamp_interface.py trailing space * [FIX][STYLE][TYPES] Refactored inverse lam scaling Put the inverse lam scaling for the importance scaling in the normalizing function(s). That way None/float operations are avoided and mypy stops yelling. * [ADD] Code of conduct The Covenant one seems great, if needed we shall change it later. * [FIX] Dirac code abides to Liskov sub prpl * Update README.md * Create CITATION.bib * Update _version.py * [FEAT] Implement multiclass logistic regression * [FIX][STYLE] Cast to cpu for logreg Instead of cast+flatten Minor style corrections * [FIX] Added ECOS as explicit dependency * Switch to default solver (Clarabel) for CVXOPT problems (#140) * [FIX] Switch to default solver (Clarabel)w/ CVXOPT Instead of ECOS, which is not shipped anymore * [FIX] Forgot Portfolio ECOS deprec * [VER] new feature (multiclass) => new minor 1.x.0 (#141) --------- Co-authored-by: Florian VINCENT <florian.vincent@inria.fr> Co-authored-by: Florian Vincent <85450305+floffy-f@users.noreply.github.com> Co-authored-by: Waiss Azizian <waiss.azizian@univ-grenoble-alpes.fr>
iutzeler
added a commit
that referenced
this pull request
Nov 29, 2024
* Version 1.1.0 (#142) * [TEST] Remove LFS-needing tests from test suite Removed by defaulty, but can be launched through `make lfstests` * [FIX] Fixed the default value of the erm mode * [FIX] Up to 5 reruns for all misc tests Just in case * Remove lbd from AD graph in IS * Add warning comment * Remove unecessary changes * [STYLE] Update _impsamp_interface.py trailing space * [FIX][STYLE][TYPES] Refactored inverse lam scaling Put the inverse lam scaling for the importance scaling in the normalizing function(s). That way None/float operations are avoided and mypy stops yelling. * [ADD] Code of conduct The Covenant one seems great, if needed we shall change it later. * [FIX] Dirac code abides to Liskov sub prpl * Update README.md * Create CITATION.bib * Update _version.py * [FEAT] Implement multiclass logistic regression * [FIX][STYLE] Cast to cpu for logreg Instead of cast+flatten Minor style corrections * [FIX] Added ECOS as explicit dependency * Switch to default solver (Clarabel) for CVXOPT problems (#140) * [FIX] Switch to default solver (Clarabel)w/ CVXOPT Instead of ECOS, which is not shipped anymore * [FIX] Forgot Portfolio ECOS deprec * [VER] new feature (multiclass) => new minor 1.x.0 (#141) --------- Co-authored-by: Florian VINCENT <florian.vincent@inria.fr> Co-authored-by: Florian Vincent <85450305+floffy-f@users.noreply.github.com> Co-authored-by: Waiss Azizian <waiss.azizian@univ-grenoble-alpes.fr> * [FIX] Dead link in readme --------- Co-authored-by: Franck Iutzeler <franck.iutzeler@gmail.com> Co-authored-by: Waiss Azizian <waiss.azizian@univ-grenoble-alpes.fr>
iutzeler
added a commit
that referenced
this pull request
Nov 29, 2024
* Version 1.1.0 (#142) * [TEST] Remove LFS-needing tests from test suite Removed by defaulty, but can be launched through `make lfstests` * [FIX] Fixed the default value of the erm mode * [FIX] Up to 5 reruns for all misc tests Just in case * Remove lbd from AD graph in IS * Add warning comment * Remove unecessary changes * [STYLE] Update _impsamp_interface.py trailing space * [FIX][STYLE][TYPES] Refactored inverse lam scaling Put the inverse lam scaling for the importance scaling in the normalizing function(s). That way None/float operations are avoided and mypy stops yelling. * [ADD] Code of conduct The Covenant one seems great, if needed we shall change it later. * [FIX] Dirac code abides to Liskov sub prpl * Update README.md * Create CITATION.bib * Update _version.py * [FEAT] Implement multiclass logistic regression * [FIX][STYLE] Cast to cpu for logreg Instead of cast+flatten Minor style corrections * [FIX] Added ECOS as explicit dependency * Switch to default solver (Clarabel) for CVXOPT problems (#140) * [FIX] Switch to default solver (Clarabel)w/ CVXOPT Instead of ECOS, which is not shipped anymore * [FIX] Forgot Portfolio ECOS deprec * [VER] new feature (multiclass) => new minor 1.x.0 (#141) --------- Co-authored-by: Florian VINCENT <florian.vincent@inria.fr> Co-authored-by: Florian Vincent <85450305+floffy-f@users.noreply.github.com> Co-authored-by: Waiss Azizian <waiss.azizian@univ-grenoble-alpes.fr> * [FEAT] Added customization of LR. * [FIX] Glob extension on tests to avoid exact ones It is disabled by default, so interpreter is launched by hand with extblob option * [FIX] Updated mypy in dependencies Needed for an inference bug on their side * [FEAT] Clarified the adaptive setting --------- Co-authored-by: Franck Iutzeler <franck.iutzeler@gmail.com> Co-authored-by: Waiss Azizian <waiss.azizian@univ-grenoble-alpes.fr>
iutzeler
pushed a commit
that referenced
this pull request
Dec 3, 2024
floffy-f
added a commit
that referenced
this pull request
Dec 3, 2024
* [TEST] Remove LFS-needing tests from test suite Removed by defaulty, but can be launched through `make lfstests` * [FIX] Fixed the default value of the erm mode * [FIX] Up to 5 reruns for all misc tests Just in case * Remove lbd from AD graph in IS * Add warning comment * Remove unecessary changes * [STYLE] Update _impsamp_interface.py trailing space * [FIX][STYLE][TYPES] Refactored inverse lam scaling Put the inverse lam scaling for the importance scaling in the normalizing function(s). That way None/float operations are avoided and mypy stops yelling. * [ADD] Code of conduct The Covenant one seems great, if needed we shall change it later. * [FIX] Dirac code abides to Liskov sub prpl * Update README.md * Create CITATION.bib * Update _version.py * [FEAT] Implement multiclass logistic regression * [FIX][STYLE] Cast to cpu for logreg Instead of cast+flatten Minor style corrections * [FIX] Added ECOS as explicit dependency * Switch to default solver (Clarabel) for CVXOPT problems (#140) * [FIX] Switch to default solver (Clarabel)w/ CVXOPT Instead of ECOS, which is not shipped anymore * [FIX] Forgot Portfolio ECOS deprec * [VER] new feature (multiclass) => new minor 1.x.0 (#141) --------- Co-authored-by: Florian VINCENT <florian.vincent@inria.fr> Co-authored-by: Florian Vincent <85450305+floffy-f@users.noreply.github.com> Co-authored-by: Waiss Azizian <waiss.azizian@univ-grenoble-alpes.fr>
floffy-f
added a commit
that referenced
this pull request
Dec 3, 2024
* Version 1.1.0 (#142) * [TEST] Remove LFS-needing tests from test suite Removed by defaulty, but can be launched through `make lfstests` * [FIX] Fixed the default value of the erm mode * [FIX] Up to 5 reruns for all misc tests Just in case * Remove lbd from AD graph in IS * Add warning comment * Remove unecessary changes * [STYLE] Update _impsamp_interface.py trailing space * [FIX][STYLE][TYPES] Refactored inverse lam scaling Put the inverse lam scaling for the importance scaling in the normalizing function(s). That way None/float operations are avoided and mypy stops yelling. * [ADD] Code of conduct The Covenant one seems great, if needed we shall change it later. * [FIX] Dirac code abides to Liskov sub prpl * Update README.md * Create CITATION.bib * Update _version.py * [FEAT] Implement multiclass logistic regression * [FIX][STYLE] Cast to cpu for logreg Instead of cast+flatten Minor style corrections * [FIX] Added ECOS as explicit dependency * Switch to default solver (Clarabel) for CVXOPT problems (#140) * [FIX] Switch to default solver (Clarabel)w/ CVXOPT Instead of ECOS, which is not shipped anymore * [FIX] Forgot Portfolio ECOS deprec * [VER] new feature (multiclass) => new minor 1.x.0 (#141) --------- Co-authored-by: Florian VINCENT <florian.vincent@inria.fr> Co-authored-by: Florian Vincent <85450305+floffy-f@users.noreply.github.com> Co-authored-by: Waiss Azizian <waiss.azizian@univ-grenoble-alpes.fr> * [FIX] Dead link in readme --------- Co-authored-by: Franck Iutzeler <franck.iutzeler@gmail.com> Co-authored-by: Waiss Azizian <waiss.azizian@univ-grenoble-alpes.fr>
floffy-f
added a commit
that referenced
this pull request
Dec 3, 2024
* Version 1.1.0 (#142) * [TEST] Remove LFS-needing tests from test suite Removed by defaulty, but can be launched through `make lfstests` * [FIX] Fixed the default value of the erm mode * [FIX] Up to 5 reruns for all misc tests Just in case * Remove lbd from AD graph in IS * Add warning comment * Remove unecessary changes * [STYLE] Update _impsamp_interface.py trailing space * [FIX][STYLE][TYPES] Refactored inverse lam scaling Put the inverse lam scaling for the importance scaling in the normalizing function(s). That way None/float operations are avoided and mypy stops yelling. * [ADD] Code of conduct The Covenant one seems great, if needed we shall change it later. * [FIX] Dirac code abides to Liskov sub prpl * Update README.md * Create CITATION.bib * Update _version.py * [FEAT] Implement multiclass logistic regression * [FIX][STYLE] Cast to cpu for logreg Instead of cast+flatten Minor style corrections * [FIX] Added ECOS as explicit dependency * Switch to default solver (Clarabel) for CVXOPT problems (#140) * [FIX] Switch to default solver (Clarabel)w/ CVXOPT Instead of ECOS, which is not shipped anymore * [FIX] Forgot Portfolio ECOS deprec * [VER] new feature (multiclass) => new minor 1.x.0 (#141) --------- Co-authored-by: Florian VINCENT <florian.vincent@inria.fr> Co-authored-by: Florian Vincent <85450305+floffy-f@users.noreply.github.com> Co-authored-by: Waiss Azizian <waiss.azizian@univ-grenoble-alpes.fr> * [FEAT] Added customization of LR. * [FIX] Glob extension on tests to avoid exact ones It is disabled by default, so interpreter is launched by hand with extblob option * [FIX] Updated mypy in dependencies Needed for an inference bug on their side * [FEAT] Clarified the adaptive setting --------- Co-authored-by: Franck Iutzeler <franck.iutzeler@gmail.com> Co-authored-by: Waiss Azizian <waiss.azizian@univ-grenoble-alpes.fr>
floffy-f
added a commit
that referenced
this pull request
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.