Skip to content

Channels: Add sort options to streams - #4224

Merged
SamantazFox merged 8 commits into
iv-org:masterfrom
src-tinkerer:stream-sort
Jul 10, 2024
Merged

Channels: Add sort options to streams#4224
SamantazFox merged 8 commits into
iv-org:masterfrom
src-tinkerer:stream-sort

Conversation

@src-tinkerer

@src-tinkerer src-tinkerer commented Nov 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Uses the same method that is used for videos. We create continuation based on the sort option. One note though, produce_channel_livestreams_continuation and produce_channel_videos_continuation are almost identical, so is it better to simply make a singular function that produces the continuation based on the content?

@src-tinkerer
src-tinkerer requested a review from a team as a code owner November 1, 2023 18:33
@src-tinkerer
src-tinkerer requested review from SamantazFox and removed request for a team November 1, 2023 18:33
@SamantazFox

SamantazFox commented Nov 13, 2023

Copy link
Copy Markdown
Member

Yes, merging the two in a single function is strongly preferred.
Also, please remove produce_channel_livestream_url. It has no use (the function you copied, produce_channel_videos_url was only used to bypass captchas back then and will be discarded one day).

@src-tinkerer

src-tinkerer commented Nov 22, 2023

Copy link
Copy Markdown
Contributor Author

I made the requested changes but couldn't test it yet because YouTube is blocked in my country, shouldn't be merged until then.

SamantazFox
SamantazFox requested changes Nov 23, 2023
View reviewed changes

@SamantazFox SamantazFox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! I'm only asking for a few style/syntax changes ^^

Comment thread src/invidious/channels/videos.cr Outdated
Comment thread src/invidious/channels/videos.cr Outdated
Comment thread src/invidious/routes/channels.cr Outdated
SamantazFox
SamantazFox reviewed Nov 28, 2023
View reviewed changes
Comment thread src/invidious/routes/channels.cr Outdated
@src-tinkerer

src-tinkerer commented Nov 30, 2023

Copy link
Copy Markdown
Contributor Author

Done, sorry for delay. Been busy with midterms.

@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Nov 30, 2023
@SamantazFox

SamantazFox commented Nov 30, 2023

Copy link
Copy Markdown
Member

@src-tinkerer yeah, sure, no problem ^^ With my 60+ pending PRs to review, that'd be quite ironic for me to ask you to reply in a timely manner x)

@github-actions github-actions Bot added the stale label Feb 29, 2024
@src-tinkerer

src-tinkerer commented Mar 17, 2024

Copy link
Copy Markdown
Contributor Author

Will test this week

@github-actions github-actions Bot removed the stale label Mar 17, 2024
@src-tinkerer

src-tinkerer commented Mar 26, 2024

Copy link
Copy Markdown
Contributor Author

Okay done testing and live stream sort works.

@iv-org iv-org deleted a comment from github-actions Bot Apr 27, 2024
@src-tinkerer

This comment has been minimized.

Sign in to view
@SamantazFox SamantazFox added in-testing This feature has been deployed and is being tested and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels May 13, 2024
@SamantazFox SamantazFox added ready and removed in-testing This feature has been deployed and is being tested labels Jun 16, 2024
@SamantazFox SamantazFox changed the title Add sort options to streams Channels: Add sort options to streams Jul 1, 2024
@SamantazFox
SamantazFox merged commit bad9209 into iv-org:master Jul 10, 2024
@SamantazFox

SamantazFox commented Jul 10, 2024

Copy link
Copy Markdown
Member

Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamantazFox SamantazFox SamantazFox approved these changes

Assignees

No one assigned

Labels

ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@src-tinkerer @SamantazFox