Skip to content

RSS: Channel + Playlist improvements - #4298

Merged
syeopite merged 4 commits into
masterfrom
unknown repository
Feb 26, 2025
Merged

syeopite merged 4 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Nov 30, 2023

Copy link
Copy Markdown

Channel feed: don't make an extra request, deprecate thumbnail field

Playlist feed: return 404 when playlist isn't found

As RSS clients can make a lot of requests pretty quickly, I removed fetching the channel to get the thumbnail for the RSS feed.
The rest of the fixes are mainly so FreeTube can detect if a channel doesn't exist via RSS

Related FreeTube PR: FreeTubeApp/FreeTube#4407

closes: #4021

@ghost
ghost self-requested a review as a code owner November 30, 2023 04:08
@ghost
ghost requested review from syeopite and removed request for a team November 30, 2023 04:08
@ghost ghost changed the title Channel RSS + Playlist improvements RSS: Channel + Playlist improvements Nov 30, 2023
@ghost
ghost force-pushed the feed-improvements branch from 480aa52 to 74d44f5 Compare December 7, 2023 14:37
Comment thread src/invidious/routes/feeds.cr Outdated
@ghost
ghost requested a review from SamantazFox January 29, 2024 22:58
@ghost
ghost force-pushed the feed-improvements branch from 4a143a0 to bee81ee Compare January 29, 2024 23:13
@ghost
ghost force-pushed the feed-improvements branch from bee81ee to 24dd4e7 Compare March 25, 2024 14:46
@ghost
ghost force-pushed the feed-improvements branch from 24dd4e7 to 10f0432 Compare April 29, 2024 22:54
@github-actions github-actions Bot added the stale label Jul 29, 2024
@ghost
ghost force-pushed the feed-improvements branch from 10f0432 to 0a8b12c Compare July 29, 2024 01:59
@ghost

ghost commented Jul 29, 2024

Copy link
Copy Markdown
Author

This PR is working and still applicable.

@github-actions github-actions Bot removed the stale label Jul 29, 2024
@ghost
ghost force-pushed the feed-improvements branch 2 times, most recently from 784768e to bc602a4 Compare August 13, 2024 19:10
Comment thread src/invidious/routes/feeds.cr Outdated
@ghost
ghost requested a review from SamantazFox August 20, 2024 22:49
@ghost
ghost force-pushed the feed-improvements branch from 7810613 to f538c44 Compare August 24, 2024 22:02
@ghost
ghost force-pushed the feed-improvements branch from f538c44 to 90918ba Compare October 1, 2024 02:02
@ghost
ghost force-pushed the feed-improvements branch from 90918ba to d18854f Compare October 30, 2024 16:59
@iv-org iv-org deleted a comment from github-actions Bot Nov 7, 2024
@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Nov 7, 2024
ChunkyProgrammer and others added 4 commits November 17, 2024 13:14
@ghost
ghost force-pushed the feed-improvements branch from d18854f to 04b0742 Compare November 17, 2024 18:14
@syeopite
syeopite merged commit 1f0a89f into iv-org:master Feb 26, 2025
@ghost
ghost deleted the feed-improvements branch February 26, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Playlist atom feeds return HTTP 200 for non-existent playlists

3 participants