Skip to content

Conversation

@engineer-dakefpv
Copy link
Contributor

@engineer-dakefpv engineer-dakefpv commented Dec 13, 2025

PR Type

Enhancement


Description

  • Introduces new flight controller target DAKEFPVH743_SLIM

  • Configures dual IMU support with multiple sensor options

  • Defines 8 motor outputs and 4 servo outputs

  • Sets up comprehensive peripheral support including OSD, SD card, and telemetry


Diagram Walkthrough

flowchart LR
  A["DAKEFPVH743_SLIM<br/>Target Definition"] --> B["Hardware Config<br/>target.h"]
  A --> C["Timer Mapping<br/>target.c"]
  A --> D["Runtime Config<br/>config.c"]
  B --> E["Dual IMU<br/>SPI Bus 1 & 4"]
  B --> F["8 Motors<br/>4 Servos"]
  B --> G["Peripherals<br/>OSD, SD, GPS"]
  C --> H["12 PWM Outputs<br/>Motor & Servo"]
  D --> I["PINIO Box<br/>Configuration"]
Loading

File Walkthrough

Relevant files
Configuration changes
target.h
Complete hardware pin and peripheral configuration             

src/main/target/DAKEFPVH743_SLIM/target.h

  • Defines board identifier and product string for DAKEFPVH743_SLIM
  • Configures dual SPI-based IMU support with MPU6500, MPU6000, ICM42605,
    and BMI270
  • Sets up 8 UART interfaces with specific pin mappings for serial
    communication
  • Defines ADC channels for voltage, current, RSSI, and airspeed
    monitoring
  • Configures OSD via MAX7456, SD card via SDIO, and LED strip support
  • Specifies PINIO pins for auxiliary outputs and peripheral control
+197/-0 
config.c
PINIO box runtime configuration setup                                       

src/main/target/DAKEFPVH743_SLIM/config.c

  • Initializes PINIO box configuration with four user-defined permanent
    IDs
  • Maps PINIO outputs to BOX_PERMANENT_ID_USER1 through USER4 for
    auxiliary control
+34/-0   
CMakeLists.txt
Build system target registration                                                 

src/main/target/DAKEFPVH743_SLIM/CMakeLists.txt

  • Registers new target with STM32H743XI MCU for build system integration
+1/-0     
Hardware configuration
target.c
Timer and IMU hardware device registration                             

src/main/target/DAKEFPVH743_SLIM/target.c

  • Registers dual IMU hardware descriptors for SPI bus 1 and 4 with
    multiple sensor variants
  • Defines timer hardware mapping for 8 motor outputs on TIM1 and TIM2
  • Configures 4 servo outputs on TIM4 with dedicated channels
  • Sets up camera control and gyro clock input on TIM15 and TIM8
  • Configures LED strip control on TIM3 for WS2811 addressable LEDs
+61/-0   

sensei-hacker and others added 5 commits December 8, 2025 10:42
Returns 8-byte bitmask indicating which logic conditions differ from defaults.
Enables configurator optimization to reduce MSP requests from 64 to 1+N.
…conditions-enabled-mask

Add MSP2_INAV_LOGIC_CONDITIONS_CONFIGURED command to make the OSD and programming tabs load much faster
Two bugs found by cppcheck static analysis:

1. fc/config.h:66 - Integer overflow in FEATURE_FW_AUTOTRIM
   - `1 << 31` could cause signed integer overflow (undefined behavior in C)
   - Fixed by using `1U << 31` for unsigned shift

2. sensors/temperature.c:101 - Buffer overrun in memset
   - sizeof(array) is already the size in bytes, so should not be multiplied by element size.
   - Fixed by using just `sizeof(sensorStatus)`
CRSF buffer overflow (rx/crsf.c):
- fullFrameLength computed from untrusted frameLength field
- Malformed packet with large frameLength could overflow crsfFrame.bytes[]
- Added bounds check against CRSF_FRAME_SIZE_MAX before writing

Dashboard sizeof bug (io/dashboard.c):
- tickerCharacters was a pointer, so sizeof() returned pointer size (4/8)
- On 64-bit systems, TICKER_CHARACTER_COUNT was 8 instead of 4
- Could read past end of string when indexing tickerCharacters[]
- Changed to array declaration and sizeof()-1 for correct count

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
…ritical-bugs

Small C nitpicks from static analysis
@github-actions
Copy link

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Dec 13, 2025

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants