Added category filtering for hotkeys in settings window by pazam-h2 · Pull Request #9957 · ihhub/fheroes2

pazam-h2 · 2025-07-01T18:44:01Z

This PR adds a visual category selector to the Hotkeys settings dialog, allowing users to filter hotkeys by category.
The category names are displayed in a 2-line layout above the hotkey list. Selecting a category filters the list accordingly.

EDIT 1: the placement of the categories have been changed to be on the left side as an organized list.

EDIT 2: added an 'All' button to have the hotkeys list unfiltered.

EDIT 3: added Category sub-title

from:

To:

Closes #9940

ihhub · 2025-07-02T13:20:14Z

Hi @pazam-h2 , this implementation contradicts the overall UX design of the game: none of text elements are clickable. An ideal solution it to embed these categories into the list itself.

pazam-h2 · 2025-07-02T22:05:18Z

Changed from text elements to just a list.
Image updated on opening post.

ihhub · 2025-07-27T07:22:18Z

Hi @pazam-h2 , could you please provide a screenshot of the window for the original 640x480 resolution?

ihhub

Hi @pazam-h2 , I added several comments in this pull request. Could you please take a look?

ihhub · 2025-08-30T13:21:32Z

I don't think that this is a good design solution for the original resolution:

pazam-h2 · 2026-06-10T21:52:05Z

Addressed the review comments:

Removed std::set and unique category extraction.
Removed the temporary ALL enum value.
Added "All" only inside the hotkeys dialog.
Iterates directly over HotKeyCategory enum values.
Moved category drawing into a helper function.
Updates the hotkey list only when selecting a different category.
Shortened the visible category labels.

Attached is an image with resolution 640x480 after adjusted values (keeping it the exact same window size):

ihhub

Hi @pazam-h2 , I added several comments here. Can you please check them?

ihhub · 2026-06-22T04:04:52Z

+    const char * getHotKeyCategoryDisplayName( const Game::HotKeyCategory category )
+    {
+        switch ( category ) {
+        case Game::HotKeyCategory::DEFAULT:
+            return "Default";
+        case Game::HotKeyCategory::GLOBAL:
+            return "Global";
+        case Game::HotKeyCategory::BATTLE:
+            return "Battle";
+        case Game::HotKeyCategory::TOWN:
+            return "Town";
+        case Game::HotKeyCategory::ARMY:
+            return "Army";
+        default:
+            return Game::getHotKeyCategoryName( category );
+        }
+    }


Can you please explain why we don't use Game::getHotKeyCategoryName(0 function instead?

I used a separate display-name helper here because the category list has much less horizontal space than the popup/title text, and some of the existing names from Game::getHotKeyCategoryName() overlap the next column.

For example, labels like "Default Action", "Global Action", "Battle Screen", "Town Screen" and "Army Action" are clear in a popup, but in the left-side category list they make the dialog feel more crowded. The shorter labels "Default", "Global", "Battle", "Town" and "Army" seem easier to scan as filter names.

I understand that duplicating names is not ideal, but that's the solution I found. If you still prefer I can keep using Game::getHotKeyCategoryName() and adjust this in another way.
My intention was only to make the category list more compact and readable.

@pazam-h2 and @ihhub We should uGame::getHotKeyCategoryName() because the category name will have to be shortened anyway in case there's a translation that is too long. Take Danish for instance ( Verdenskor should be Verdenskort ):

@zenseii
Makes sense. I see @ihhub has now switched it to Game::getHotKeyCategoryName() and adjusted the dialog width accordingly, which should handle this more consistently across translations.

@ihhub -
Widening the dialog was a fix I tried at the start of this PR, and it got rejected for the reason that the dialog cuts off at 640x480 resolution with that width.

I don't mind it at all, just making sure it won't be overlooked.

Hi @pazam-h2 , I am still making the changes so please wait for the end result :)

zenseii · 2026-08-27T17:27:33Z

@ihhub and @pazam-h2. Personally I think Pazam's implementation is convenient because it requires less use of the scroll bar and as such it gives quicker access to the desired category.

github-actions Bot assigned pazam-h2 Jul 1, 2025

This comment was marked as outdated.

Sign in to view

zenseii added improvement New feature, request or improvement ui UI/GUI related stuff labels Jul 6, 2025

zenseii added this to the 1.1.10 milestone Jul 6, 2025

ihhub modified the milestones: 1.1.10, 1.1.11 Jul 20, 2025

ihhub requested changes Jul 28, 2025

View reviewed changes

ihhub marked this pull request as draft July 29, 2025 11:45

ihhub modified the milestones: 1.1.11, 1.1.12 Sep 14, 2025

ihhub modified the milestones: 1.1.12, 1.1.13 Nov 9, 2025

ihhub modified the milestones: 1.1.13, 1.2.0 Dec 20, 2025

Add category filter to hotkeys dialog. Include all requested fixes

7efc094

pazam-h2 force-pushed the hotkey-category-filter branch from 58aa00c to 7efc094 Compare June 10, 2026 21:49

This was referenced Jun 11, 2026

Add hotkey categories into the corresponding dialog #10718

Closed

Categories in the Hotkey Options Screen #9940

Open

pazam-h2 requested a review from ihhub June 16, 2026 08:04

format fix

e1b7e83

ihhub requested changes Jun 22, 2026

View reviewed changes

ihhub marked this pull request as ready for review June 22, 2026 04:05

Address hotkey category filter review comments

9936b0e

pazam-h2 requested a review from ihhub June 27, 2026 23:40

ihhub added 5 commits August 29, 2026 20:37

Merge branch 'master' into hotkey-category-filter

da3b5a5

Use Game::getHotKeyCategoryName() function

c72e23d

Revert the changes (AI suspected stupidity)

85d8890

Make the dialog wider but to fit all screens

b9f41cd

Update dialog_hotkeys.cpp

e5d754f

Uh oh!

Conversation

pazam-h2 commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

ihhub commented Jul 2, 2025

Uh oh!

pazam-h2 commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihhub commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihhub left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ihhub commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pazam-h2 commented Jun 10, 2026

Uh oh!

ihhub left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ihhub Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

pazam-h2 Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zenseii Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

pazam-h2 Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

pazam-h2 Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

ihhub Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

zenseii commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pazam-h2 commented Jul 1, 2025 •

edited

Loading

pazam-h2 commented Jul 2, 2025 •

edited

Loading

ihhub commented Jul 27, 2025 •

edited

Loading

ihhub commented Aug 30, 2025 •

edited

Loading

pazam-h2 Jun 22, 2026 •

edited

Loading

zenseii commented Aug 27, 2026 •

edited

Loading