Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: iii-hq/iii/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe daemon registers shutdown-signal handlers before polling exit watches. OTLP metric ingestion now uses a helper that accepts optional storage. The changes also update the SIGTERM integration test and OTLP ingestion tests. ChangesDaemon shutdown signals
OTLP metric ingestion
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The shutdown and metric-ingestion changes appear ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Split out of #2198 (which is now scoped to #2178 only), as requested in review, to ease review and bisecting. Neither change touches trigger handling.
Changes
fix(worker): install the shutdown signal handlers before exit-watch reports readiness (crates/iii-worker/src/daemon_exit.rs), so a signal sent right after readiness is not missed. Covered bysandbox_daemon_exit_integration.test(engine): OTLP ingestion edge-case tests now use owned metric storage through an extractedingest_otlp_metrics_into(json, storage)helper (otel.rs), instead of clearing the process-wide store. This fixes a CI flake (test_ingest_metrics_multiple_resourcescounted 3 metrics instead of 2) caused by a non-serialized test writing to the same global store. Production behaviour is unchanged:ingest_otlp_metricsstill ingests into the global store...._ignores_foreign_writertest.Validation
cargo fmt --checkokcargo test -p iii --lib workers::observability: 442 passedcargo test -p iii-worker daemon_exit: 5 passed + 1 integration passedSummary by CodeRabbit