Repository navigation
fix(cpp): resync headers, sources and bindings so the extension builds - #3306
Open
LuisFigueroaG wants to merge 1 commit into
Open
LuisFigueroaG wants to merge 1 commit into
LuisFigueroaG wants to merge 1 commit into
Conversation
Several merges left declarations, definitions and bindings out of sync, so the native extension no longer compiled on main. - frame.h: restore memory_usage(bool deep) and describe() declarations that match frame.cpp, plus the Frame(size_t row_count) constructor used by the bindings and the cleaning tests. - cleaning.h: declare cast_types as it is defined in cleaning.cpp (CastResult with a CastErrors policy) instead of two Frame overloads that were never implemented. - csv_reader.cpp: restore the CsvParser::is_null_sentinel definition, which was dropped while its declaration and callers were kept. - bind_arnio.cpp: remove the stray closing brace that ended the module early, drop the create_rolling_windows binding (no native implementation exists anymore), and bind cast_types through the errors="raise"|"coerce"|"report" wrapper again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@LuisFigueroaG is attempting to deploy a commit to the xtylishanish-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several merges left headers, sources and bindings out of sync, so the native extension stopped compiling on
mainand every CI job that builds it fails. This puts them back in sync with the smallest changes I could make:frame.h: declarememory_usage(bool deep = false)anddescribe()as defined inframe.cpp, and restore theFrame(size_t row_count)constructor that the bindings andcpp/tests/test_cleaning.cppstill usecleaning.h: declarecast_typesascleaning.cppdefines it (CastResultwith aCastErrorspolicy) instead of twoFrameoverloads that were never implementedcsv_reader.cpp: restore theCsvParser::is_null_sentineldefinition (declaration and callers were kept, definition was dropped)bind_arnio.cpp: remove the stray}that endedPYBIND11_MODULEearly, drop thecreate_rolling_windowsbinding (no C++ implementation left), and bindcast_typesthrough theerrors="raise"|"coerce"|"report"wrapper returning(frame, failures), which is whatcleaning.pycallsLinked issue
Fixes #3305
Type of change
Area
Testing
Python 3.12, cmake 4.4, ninja, macOS (clang):
-DARNIO_BUILD_CPP_TESTS=ON(core, extension, benchmark, all test binaries): no errorspip install -e .: builds and installs;Frame(3),memory_usage(deep=True)and the threecast_typesmodes work when loading the extension directlyctest:test_column,test_cleaningandtest_csv_parserpass;test_framepasses 13/14. The failing case is "add_column throws on duplicate column name". That duplicate-name check was dropped in an earlier merge, and the failure was hidden on main because nothing compiled. It's a behaviour bug, so I left it out of this PR.asan.yml: builds, no sanitizer reports, same singletest_framefailuregit clang-format --diff upstream/main: nothing to change on the edited linesmake test: can't run yet.import arniostill fails on main for Python-side reasons outside this PR (cleaning.pyis fixed in fix: dedupe cleaning.py and restore helpers dropped by bad merge #3304;frame.py,io.py,quality.py,schema.pyandconvert.pyhave similar merge damage)Contributor checklist
Maintainer notes
Follow-ups I noticed but kept out of scope:
Frame.describebinding,from_dict(..., row_count),skip_rows/decimal_separatorin the CSV config). They compile, but will raise once the Python side imports again.rolling_windowis still exported in__all__and tested intests/test_rolling_window.py, but has no implementation anymore.Frame(std::vector<Column>, size_t)doesn't setrow_count_known_.🤖 Generated with Claude Code