Skip to content

test: use typed unmount container - #2125

Open
unohq[bot] wants to merge 1 commit into
mainfrom
uno/type-will-unmount-container-41
Open

unohq[bot] wants to merge 1 commit into
mainfrom
uno/type-will-unmount-container-41

Conversation

@unohq

@unohq unohq Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove redundant HTMLElement assertions from the useWillUnmount test
  • rely on Testing Library's derived container type

Verification

  • pnpm exec vitest run src/__tests__/useWillUnmount.spec.tsx (2 tests passed)
  • pnpm exec tsc --noEmit -p tsconfig.json
  • pnpm exec eslint src/__tests__/useWillUnmount.spec.tsx (0 errors, 1 pre-existing warning)
  • git diff --check

@codesandbox

codesandbox Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel

vercel Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
rooks Ready Ready Preview Aug 19, 2026 11:46pm

@unohq
unohq Bot marked this pull request as ready for review August 19, 2026 23:45
@mergify

mergify Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

This branch was successfully deployed

1 active deployment
Preview — aa4d77e4 Deployed Aug 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants