Skip to content

test: guard local storage result element - #2127

Open
unohq[bot] wants to merge 1 commit into
mainfrom
uno/guard-local-storage-result-43
Open

unohq[bot] wants to merge 1 commit into
mainfrom
uno/guard-local-storage-result-43

Conversation

@unohq

@unohq unohq Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace an unchecked HTMLElement assertion in the suspense local-storage test helper
  • narrow the queried element with an instanceof HTMLElement guard before updating it

Verification

  • pnpm exec vitest run src/__tests__/useSuspenseLocalStorageState.spec.tsx (18 tests passed)
  • pnpm exec tsc --noEmit -p packages/rooks/tsconfig.json
  • pnpm exec eslint src/__tests__/useSuspenseLocalStorageState.spec.tsx
  • git diff --check

@codesandbox

codesandbox Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@vercel

vercel Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
rooks Ready Ready Preview Aug 20, 2026 12:28am

@unohq
unohq Bot marked this pull request as ready for review August 20, 2026 00:26
@mergify

mergify Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

This branch was successfully deployed

1 active deployment
Preview — c581944a Deployed Aug 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants