Skip to content

Spec: Stationary subtype support is all-or-nothing - #537

Merged
toji merged 2 commits into
masterfrom
stationary-subtypes
Feb 25, 2019
Merged

Spec: Stationary subtype support is all-or-nothing#537
toji merged 2 commits into
masterfrom
stationary-subtypes

Conversation

@toji

@toji toji commented Feb 21, 2019

Copy link
Copy Markdown
Member

Fixes #532 and #533

@toji
toji requested a review from NellWaliczek February 21, 2019 23:05

@ddorwin ddorwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Comment thread index.bs Outdated

Note: The {{position-disabled}} subtype is primarily intended for use with pre-rendered media such as panoramic photos or videos. It should not be used for most other media types due to user discomfort associated with the lack of a neck model or full positional tracking.

Devices which support {{XRReferenceSpaceType/stationary}} reference spaces MUST support all {{XRStationaryReferenceSpace/subtype}}s.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/which/that/

Comment thread index.bs Outdated
An {{XRStationaryReferenceSpace}} represents a tracking space that the user is not expected to move around within. Tracking in a {{stationary}} reference space is optimized for the assumption that the user will not move much beyond their starting point, if at all. For devices with [=6DoF=] tracking, {{stationary}} reference spaces should emphasize keeping the origin stable relative to the user's environment.

<pre class="idl">
enum XRStationaryReferenceSpaceSubtype {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding #532:
This change moves the IDL closer to the definition it will link to. However, these values are most relevant in XRSession, and the definitions actually describe the behavior of values passed to XRSession::requestReferenceSpace() (as part of XRReferenceSpaceOptions). As noted in #532, it probably makes sense to move the definitions/prose and IDL (including other things like XRReferenceSpaceOptions to XRSession.

Comment thread index.bs Outdated

Note: The {{position-disabled}} subtype is primarily intended for use with pre-rendered media such as panoramic photos or videos. It should not be used for most other media types due to user discomfort associated with the lack of a neck model or full positional tracking.

Devices which support {{XRReferenceSpaceType/stationary}} reference spaces MUST support all {{XRStationaryReferenceSpace/subtype}}s.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to replace
{{XRStationaryReferenceSpace/subtype}}s
with
{{XRStationaryReferenceSpaceSubtype}} values

@NellWaliczek NellWaliczek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I'm also inclined towards David's point that the reference space options should be defined near the function that receives them (especially in light of not wanting to have an XRReferenceSpace attribute reflecting the requested values).

@toji

toji commented Feb 23, 2019

Copy link
Copy Markdown
Member Author

Thanks David and Nell! Addressed both of David's nits and moved the subtype description up in the file. PTAL!

@toji
toji merged commit c9086a8 into master Feb 25, 2019
@toji
toji deleted the stationary-subtypes branch February 25, 2019 21:13
@AdaRoseCannon AdaRoseCannon added the ed:spec Include in newsletter, spec change label Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ed:spec Include in newsletter, spec change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants