Skip to content

Updates ignite doctor to show boilerplate version - #1415

Merged
jamonholmgren merged 1 commit into
masterfrom
feat/ignite-attach
May 5, 2019
Merged

Updates ignite doctor to show boilerplate version#1415
jamonholmgren merged 1 commit into
masterfrom
feat/ignite-attach

Conversation

@jamonholmgren

@jamonholmgren jamonholmgren commented May 5, 2019

Copy link
Copy Markdown
Member

This updates Ignite CLI to do the following:

  1. Adds the boilerplate version into the ./ignite/ignite.json project config file
  2. Ensures ignite attach is run after every boilerplate to remove requirement to have ignite/ignite.json in boilerplates
  3. Adds git initialization to Ignite CLI, to remove requirement to handle git in boilerplates
  4. Updates ignite doctor to show everything in the ignite/ignite.json project config file

Fixes #1406.

image

@jamonholmgren

jamonholmgren commented May 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Looking into the CI failure. It passes locally. 🙄

EDIT: Looks like rebuilding worked. 🤷

@jamonholmgren
jamonholmgren requested a review from ryanlntn May 5, 2019 01:07
@jamonholmgren jamonholmgren mentioned this pull request May 5, 2019
Merged
ryanlntn
ryanlntn approved these changes May 5, 2019
View reviewed changes

@ryanlntn ryanlntn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This cleans up a couple things too. 🙂

@ruddell

ruddell commented May 5, 2019

Copy link
Copy Markdown
Contributor

I really like #4 since I store some extra options in the ignite.json. Not really a blocker but one thing that seems weird is that for true values, it prints true. For false values it prints -.

Ignite
  ignite-cli          3.0.3           
  name                JwtApp2         
...
  boilerplate         ignite-jhipster 
  authType            jwt             
  searchEngine        -               
  websockets          -               
  detox               -               
  askToOverwrite      true

@jamonholmgren
jamonholmgren merged commit 9961220 into master May 5, 2019
@jamonholmgren
jamonholmgren deleted the feat/ignite-attach branch May 5, 2019 21:14
infinitered-circleci pushed a commit that referenced this pull request May 5, 2019
@semantic-release-bot
chore(release): 3.1.0 [skip ci]
cfcee0f 
# [3.1.0](v3.0.3...v3.1.0) (2019-05-05)

### Bug Fixes

* **cli:** Remove beta tag from jhipster boilerplate, fix name spelling ([#1414](#1414) by [@ruddell](https://github.com/ruddell)) ([e705e06](e705e06))

### Features

* **cli:** Updates ignite doctor to show boilerplate version ([#1415](#1415)) ([9961220](9961220))
@infinitered-circleci

infinitered-circleci commented May 5, 2019

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanlntn ryanlntn ryanlntn approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Doctor, doctor what version of the boilerplate was used for the new project?

4 participants

@jamonholmgren @ruddell @infinitered-circleci @ryanlntn