Repository navigation
Show globally-installed packages in ignite doctor - #1586
Merged
Merged
Conversation
…g it (also, join the output without commas)
jamonholmgren
approved these changes
Jan 4, 2021
jamonholmgren
left a comment
Member
There was a problem hiding this comment.
Looks great. Tested on my machine and it works, including without Yarn installed.
jamonholmgren
pushed a commit
that referenced
this pull request
Jan 4, 2021
# [6.1.0](v6.0.0...v6.1.0) (2021-01-04) ### Bug Fixes * **i18n:** Fix grep path in i18n test ([#1589](#1589) by [@leonyjiang](https://github.com/leonyjiang)) ([fd1338e](fd1338e)) ### Features * **cli:** Show globally-installed packages in `ignite doctor` ([#1586](#1586) by [@bryanstearns](https://github.com/bryanstearns)) ([465f3c1](465f3c1))
Collaborator
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn ci:testjest tests pass with new tests, if relevantDescribe your PR
@nirre7 had a problem that was caused by an older version of react-native-cli being installed globally (which is no longer recommended); he suggested having Ignite warn when this happens. https://infiniteredcommunity.slack.com/archives/CD8UA5RJ4/p1609336353033800?thread_ts=1609248567.028100&cid=CD8UA5RJ4
I think that's a great idea, and I thought it'd be useful as a preliminary step to see all the globally-installed packages in
ignite doctor's output, so that's what this PR adds. Becausenpmandyarnstore global packages in different places, it lists them separately -- the Javascript section of its output now looks like this (I just have one package in each group):