Repository navigation
Copy over gitignore properly; fixes #1776 - #1781
Merged
Merged
Conversation
infinitered-circleci
pushed a commit
that referenced
this pull request
Aug 31, 2021
## [7.4.1](v7.4.0...v7.4.1) (2021-08-31) ### Bug Fixes * **cli:** Copy over gitignore properly; fixes [#1776](#1776) ([#1781](#1781) by [@jamonholmgren](https://github.com/jamonholmgren) and [@yulolimum](https://github.com/yulolimum)) ([8d0084f](8d0084f))
Collaborator
|
🎉 This PR is included in version 7.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1776,
npm packseems to no longer copy over the .gitignore (nor the .npmignore that @bryanstearns used in #1582).So, we're doing what everyone else seems to do, and that is rename the file (in this case, we're copying it to
.gitignore.template) for publishing and then copy it back fornpx ignite-cli new.I'll release this and test it after release, since that's the only reliable way to really test it.