Repository navigation
fix(cli): correct mobx removal when using prompts - #2949
Merged
Merged
Conversation
robinheinze
approved these changes
May 14, 2025
robinheinze
left a comment
Member
There was a problem hiding this comment.
Great find, Frank! Thanks for jumping on this :)
Contributor
|
Thanks for fixing this! Well done everyone! |
markrickert
approved these changes
May 15, 2025
Member
|
Just verified that this fix works as expected and it does! Left screenshot is |
infinitered-circleci
pushed a commit
that referenced
this pull request
May 20, 2025
## [10.4.1](v10.4.0...v10.4.1) (2025-05-20) ### Bug Fixes * **cli:** correct mobx removal when using prompts ([#2949](#2949) by [@frankcalise](https://github.com/frankcalise)) ([73e9809](73e9809)) * **docs:** updated the doc for i18n translate to reflect proper usage of the translation keys ([#2924](#2924)) [skip ci] ([7bb8c5c](7bb8c5c)) * **Header:** change Header's pointerEvents="none" from a prop to a style ([#2933](#2933)) [skip ci] ([a0d305f](a0d305f)) * **tests:** fix i18n tests failing because of a rogue grep and regex not understanding comments ([#2950](#2950)) [skip ci] ([17dd1a4](17dd1a4)), closes [#2924](#2924)
Collaborator
|
🎉 This PR is included in version 10.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--state nonebut failed during the promptsuseDefaultis only meant to apply the default value if--yesis applied, so even though we skipped the prompt for removing the demo application (as intended, because the user wanted to remove MST), we didn't later remove the code, only markupChecklist