chore: Use reflect helpers from the standard library - #19740
Open
SungJin1212 wants to merge 1 commit into
Open
SungJin1212 wants to merge 1 commit into
SungJin1212 wants to merge 1 commit into
Conversation
2 tasks
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the modernize linter series (follow-up to #19675), split out of #19725 as requested in review.
This PR uses
reflect.TypeForinstead ofreflect.TypeOf((*T)(nil)).Elem(),reflect.TypeAssertinstead ofValue.Interface().(T), and iteratesreflect.Value.Fields()where available (analyzers:reflecttypefor,reflecttypeassert,stditerators).The rewrite is the output of the modernize linter with only the listed analyzer(s) enabled, applied via
golangci-lint run --fixfor GOOS=darwin, linux and windows, followed bygoimports/golangci-lint fmtto drop imports left unused and regroup new ones.Checklist
Related issues
resolves #