Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a TODO() function and NotImplementedError exception class to the stdlib, following Kotlin's pattern for marking unimplemented code sections.
- Introduces
NotImplementedErrorexception class that extends the standard Error - Adds
TODO()function with overloads for optional reason parameter - Includes comprehensive test coverage and documentation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/stdlib/common/index.ts | Exports the new TODO function and NotImplementedError exception |
| src/stdlib/common/exceptions/NotImplementedError.ts | Implements the NotImplementedError exception class |
| src/stdlib/common/exceptions/NotImplementedError.spec.ts | Test coverage for NotImplementedError |
| src/stdlib/common/TODO.ts | Implements TODO function with function overloads |
| src/stdlib/common/TODO.spec.ts | Test coverage for TODO function |
| docs/api/core/kotlin-stdlib/kotlin/-t-o-d-o.md | API documentation for TODO function |
| docs/.vitepress/config.mts | Adds TODO function to documentation navigation |
Comments suppressed due to low confidence (2)
src/stdlib/common/exceptions/NotImplementedError.spec.ts:10
- The test only verifies the error name but doesn't test the default message. Consider adding a test to verify the default message 'An operation is not implemented.' is thrown when no custom message is provided.
expect(throwNotImplementedError).toThrowError(
src/stdlib/common/exceptions/NotImplementedError.spec.ts:16
- Missing test coverage for custom error messages. The NotImplementedError constructor accepts a custom message parameter, but there's no test verifying that custom messages are properly set.
})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
TODO()function andNotImplementedErrorerror.