Enhance Result and runCatching to support async#9
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Result and runCatching utilities to support asynchronous functions, allowing them to work with both synchronous and Promise-returning functions while maintaining backward compatibility.
Key changes:
- Added async support to
runCatchingfunction with proper overloads - Enhanced
Resultclass methods (map,mapCatching,recover,recoverCatching) to handle Promise-returning transform functions - Added comprehensive test coverage for async scenarios
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/stdlib/common/Promise.ts |
New type definitions for MaybePromise and NonPromise to support async patterns |
src/stdlib/common/runCatching.ts |
Enhanced with overloads and implementation to handle both sync and async functions |
src/stdlib/common/Result.ts |
Added async support to transformation methods with proper overloads and Promise handling |
src/stdlib/common/runCatching.spec.ts |
Added test cases for async runCatching scenarios |
src/stdlib/common/Result.spec.ts |
Comprehensive test coverage for async Result methods |
docs/api/core/kotlin-stdlib/kotlin/run-catching.md |
Updated documentation to reflect new async-aware type signature |
docs/api/core/kotlin-stdlib/kotlin/-result.md |
Updated documentation for Result methods with async overloads |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
ResultandrunCatching()to support asynchronous functions.