Repository navigation
Dual boot application (Rails 7.0 and 7.1) - #150
Merged
Merged
Conversation
Set up CI to run two jobs per Rails version Address legacy connection handling
Add BUNDLE_GEMFILE build arg to Dockerfile so the image can be built with either Gemfile (Rails 7.0) or Gemfile.next (Rails 7.1). Copy all four Gemfile/lockfile variants into the image. Update docker-compose.yml to pass BUNDLE_GEMFILE as both a build arg and runtime env var, defaulting to Gemfile. Update CI workflow to use the matrix gemfile for docker compose build, up, and exec commands, removing the separate "Install gems" step since the correct gems are now installed at image build time. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Looks fine to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This is a WIP PR to set up dual booting between Rails 7.0 and 7.1This is a PR to run the test suite with Rails 7.0 and 7.1.
It will:
If the test suite with Rails 7.1 is passing, then it's a good sign that we can move on to QA Rails 7.1 in staging.
Please check it out.
Thanks!