Enhance error messages for oracles by performing validation before passing to Datasworn - #597
Merged
Merged
Conversation
cwegrzyn
force-pushed
the
better-oracle-validation
branch
from
September 1, 2025 18:45
b3be0f9 to
e729f2b
Compare
It's been unable to report errors correctly since the true-myth migration, because of structured cloning clobbering prototypes and the twice-cursed TS type system assuring me the types were still the same.
cwegrzyn
marked this pull request as ready for review
September 3, 2025 10:49
cwegrzyn
force-pushed
the
better-oracle-validation
branch
from
September 3, 2025 10:51
e78d133 to
ee3b76f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This performs content validation before passing content to Datasworn. This allows us to filter problematic files before passing to Datasworn, resulting in partial builds and richer error information.
This also renders that error info in the homebrew inspector, and fixes an issue with the Homebrew Inspector that popped up after migrating to true-myth. (It was broken and now it is not...)