Skip to content

Repository URL in appendix is no longer substituted #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agahkarakuzu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Repository URL in appendix is no longer substituted #2129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89bb5ef
Substitute {binder_url} and {repo_url} in the appendix again
Aug 31, 2026
9ca9d58
Inline comment cleanup
Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions binderhub/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,16 @@ async def get(self, provider_prefix, _unescaped_spec):
else:
build.push_secret = ""

# appendix is a string template
if build.appendix:
build.appendix = build.appendix.format(
binder_url=self.binder_launch_host + self.binder_request,
persistent_binder_url=self.binder_launch_host
+ self.binder_persistent_request,
repo_url=repo_url,
ref_url=self.ref_url,
)

self.build = build

with BUILDS_INPROGRESS.track_inprogress():
Expand Down
Loading