Conversation
Contributor
|
|
2 tasks
krassowski
pushed a commit
to jupyterlab/jupyterlab
that referenced
this pull request
Aug 10, 2026
## References Fixes a bug to properly handle drive names for root-level sessions. This was already working as expected for nested paths, but not for the root-level folder, mostly by accident with the use of `dirname` because: - `FileSystemAccess:folder/notebook.ipynb` would give `FileSystemAccess:folder` - `FileSystemAccess:notebook.ipynb` would give an empty string This should help with jupyterlite/jupyterlite#1998 See also: jupyterlite/jupyterlite#1794 ## Code changes - [x] Preserve drive name for root-level sessions - [x] Update existing test ## User-facing changes None ## Backwards-incompatible changes None ## AI usage - **YES**: Some or all of the content of this PR was generated by AI. - **YES**: The human author has carefully reviewed this PR and run this code (keep this PR "draft" until the answer is YES) - AI tools and models used: GPT 5.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Looking into #1794
This will likely require a change in JupyterLab too to be able to remove the workaround here. Opening early to have it on the radar for 4.7 / 0.9.0: jupyterlab/jupyterlab#19157
Code changes
SessionContextworkaroundUser-facing changes
None
Backwards-incompatible changes
None