Conversation
Contributor
|
|
Contributor
There was a problem hiding this comment.
馃煛 Changes recommended
Double-decoding path parameters breaks valid filenames containing percent characters.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Improves direct navigation and URL routing for Jupyter Notebook pages.
Changes:
- Redirects missing or directory paths to the file browser.
- Adds missing-file dialogs and loadable folder URLs.
- Adds routing documentation and UI coverage.
File summaries
| File | Description |
|---|---|
packages/application-extension/src/index.tsx |
Implements routing, validation, redirects, and URL transformation. |
ui-tests/test/routing.spec.ts |
Tests notebook-page routing scenarios. |
docs/howto/configure/urls.md |
Documents Notebook URL parameters. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| return; | ||
| } | ||
| const files = paths.map((path) => decodeURIComponent(path)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #1201
Code changes
/notebooks/directly redirects to/tree?path=, and update the URL when navigating sub directories in the file browserUser-facing changes
jupyterlite-notebooks-redirect.mp4
Backwards-incompatible changes
None