Fix link to RFC (parameter choice) - #2
Merged
Merged
Conversation
FX-Wood
commented
Oct 27, 2022
| - **encoding** : Encoding for the returned hash type ('raw', 'hex' or 'b64'). | ||
|
|
||
| For assistance with parameter selection refer to the [draft RFC](https://www.ietf.org/id/draft-irtf-cfrg-argon2-10.txt), in particular "Chapter 4: Parameter Choice". | ||
| For assistance with parameter selection refer to the [draft RFC](https://www.rfc-editor.org/rfc/rfc9106.html#section-4), in particular "Chapter 4: Parameter Choice". |
Contributor
Author
There was a problem hiding this comment.
Notice that it's an anchor link to section 4, should the paragraph reflect this?
Owner
There was a problem hiding this comment.
Either is fine, thank you for updating the documentation 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I am making a hobby project and storing some passwords using argon. Thanks for making this implementation, it will be nice to use.
I noticed that your link to the argon2 RFC is broken for me (maybe because it's out of draft now?) and found a link that works (for me at least): https://www.rfc-editor.org/rfc/rfc9106.html
This IETF bloggish post How to read RFCs recommends using https://www.rfc-editor.org to read RFCs, that's why I chose this host to link to.