Skip to content

Remove six dependency in favor pip's vendored six - #1240

Merged
jdufresne merged 1 commit into
jazzband:masterfrom
jdufresne:vendor-six
Nov 25, 2020
Merged

jdufresne merged 1 commit into
jazzband:masterfrom
jdufresne:vendor-six

Conversation

@jdufresne

Copy link
Copy Markdown
Member

Allows removing a dependency of pip-tools. The package is already
guaranteed to exist within pip, so might as well use it.

As more and more projects are dropping Python 2 support, they too are
dropping six as a dependency. As more projects drop six, this will
eventually remove the need for projects to pull in six as a transient
dependency.

When pip eventually drops Python 2 support, it will also drop six. When
that day comes, pip-tools can also drop Python 2 support, so the
eventual lack of six should not be an issue.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@jdufresne jdufresne added refactor Refactoring code pip Related to pip dependency Related to a dependency labels Nov 22, 2020
@jdufresne jdufresne added this to the 5.5.0 milestone Nov 22, 2020

@atugushev atugushev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! Thanks 👍

Allows removing a dependency of pip-tools. The package is already
guaranteed to exist within pip, so might as well use it.

As more and more projects are dropping Python 2 support, they too are
dropping six as a dependency. As more projects drop six, this will
eventually remove the need for projects to pull in six as a transient
dependency.

When pip eventually drops Python 2 support, it will also drop six. When
that day comes, pip-tools can also drop Python 2 support, so the
eventual lack of six should not be an issue.
@jdufresne
jdufresne merged commit a0c7653 into jazzband:master Nov 25, 2020
@jdufresne
jdufresne deleted the vendor-six branch November 25, 2020 21:54
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency Related to a dependency pip Related to pip refactor Refactoring code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants