Repository navigation
No download dir for editable - #538
Merged
Merged
Conversation
Using a `download_dir` will make `pip` export the cloned repo via `reqset._prepare_file` and `git-checkout-index`, which then makes `python setup.py egg_info` fail, when [setuptools_scm](https://github.com/pypa/setuptools_scm) is used. Fixes #369.
Contributor
Author
|
@vphilippon I'd like to get this in the next release as it replaces #385. Can we get this done? |
vphilippon
self-requested a review
July 4, 2017 13:28
vphilippon
requested changes
Jul 4, 2017
vphilippon
left a comment
Member
There was a problem hiding this comment.
I've noted a few things to do with the new test.
Everything else looks good.
|
|
||
|
|
||
| def test_editable_package_vcs(tmpdir): | ||
| vcs_package = 'git+git://github.com/pytest-dev/pytest-django#egg=pytest-django' |
Member
There was a problem hiding this comment.
I would pin this to the current latest commit of pytest-django master branch.
The pytest-django package could stop using setuptools_scm.
Also, if they break the master branch for a while, I'd rather not have our tests fail on that.
| '--rebuild']) | ||
| print(out.output) | ||
| assert out.exit_code == 0 | ||
| assert vcs_package in out.output |
Member
There was a problem hiding this comment.
Add a check that pytest is also in the output, as it's one of pytest-django's install_requires.
We want to make sure that we still collect the subdependencies.
Contributor
Author
|
@vphilippon updated. |
Member
|
Thanks for the contribution! |
This was referenced Sep 27, 2017
This was referenced Sep 27, 2017
This was referenced Nov 19, 2017
This was referenced Nov 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rebase of #385.