Repository navigation
Apply version constraints specified with package upgrade option - #694
Merged
Merged
Conversation
vphilippon
self-requested a review
November 16, 2018 20:59
vphilippon
reviewed
Nov 16, 2018
vphilippon
left a comment
Member
There was a problem hiding this comment.
Hello @richafrank, thanks for the contribution!
For the test wheel, the easiest way would be to write a simple setup.py like this:
from setuptools import setup
setup(
name='small-fake-b',
version='0.3',
)
then run python setup.py bdist_wheel --universal --dist-dir ./ to generate the wheel in the current directory.
For the change itself, LGTM 👍
richafrank
force-pushed
the
upgrade_packages-version
branch
from
November 18, 2018 18:53
7491559 to
bc1d8b8
Compare
Contributor
Author
|
Thanks @vphilippon! I updated the test wheel. |
Member
|
Thanks @richafrank for the contribution, it's really appreciated :) |
Contributor
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--upgrade-packageoption (For Upgrade specific package to a specific version fails to pick up the version constraint #649). The test I added requires a new binary wheel in the test data. I saw existing wheels there, but I'm not sure how they were generated, so I copied the contents of an existing one. Thus, the version in the wheel's contents is incorrect. Please let me know the best way to generate this test data!Changelog-friendly one-liner: Apply version constraints specified with package upgrade option
Contributor checklist