Skip to content

Support the flag --trusted-host in pip-sync. - #777

Merged
atugushev merged 2 commits into
jazzband:masterfrom
firebirdberlin:trusted-host
Apr 3, 2019
Merged

atugushev merged 2 commits into
jazzband:masterfrom
firebirdberlin:trusted-host

Conversation

@firebirdberlin

@firebirdberlin firebirdberlin commented Apr 2, 2019 •

Copy link
Copy Markdown
Contributor

Changelog-friendly one-liner: Support the flag --trusted-host in pip-sync.

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@codecov

codecov Bot commented Apr 2, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #777 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #777      +/-   ##
=========================================
+ Coverage    97.9%   97.9%   +<.01%     
=========================================
  Files          34      34              
  Lines        1955    1959       +4     
  Branches      252     254       +2     
=========================================
+ Hits         1914    1918       +4     
  Misses         29      29              
  Partials       12      12
Impacted Files Coverage Δ
tests/test_cli_sync.py 100% <ø> (ø) ⬆️
piptools/scripts/sync.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b732ff...ac677f7. Read the comment docs.

@atugushev atugushev left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Could you also provide a test for the changes?

Comment thread piptools/scripts/sync.py Outdated
Comment thread piptools/scripts/sync.py Outdated
@firebirdberlin
firebirdberlin force-pushed the trusted-host branch 2 times, most recently from a7ee4c5 to 40f97aa Compare April 3, 2019 07:43
@firebirdberlin

Copy link
Copy Markdown
Contributor Author

I added tests and made all automated tests pass. I also tested the new feature within my current environment.

@atugushev atugushev added enhancement Improvements to functionality and removed Needs tests labels Apr 3, 2019
@atugushev atugushev added this to the 3.6.0 milestone Apr 3, 2019
@atugushev
atugushev merged commit 749174d into jazzband:master Apr 3, 2019
@atugushev

Copy link
Copy Markdown
Member

@firebirdberlin thanks! I'll prepare a new release within the next 24 hours.

@atugushev

Copy link
Copy Markdown
Member

pip-tools v3.6.0 is released

@firebirdberlin
firebirdberlin deleted the trusted-host branch April 5, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvements to functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants