Skip to content

Show default index url provided by pip - #735

Merged
atugushev merged 1 commit into
jazzband:masterfrom
atugushev:help-default-index-url
Feb 28, 2019
Merged

Show default index url provided by pip#735
atugushev merged 1 commit into
jazzband:masterfrom
atugushev:help-default-index-url

Conversation

@atugushev

@atugushev atugushev commented Feb 15, 2019

Copy link
Copy Markdown
Member

Closes #705.

Changelog-friendly one-liner: Show default index url provided by pip

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added this to the 3.4.0 milestone Feb 15, 2019
blueyed
blueyed reviewed Feb 15, 2019
View reviewed changes
Comment thread piptools/scripts/compile.py
@codecov

codecov Bot commented Feb 15, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #735 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   86.25%   86.33%   +0.07%     
==========================================
  Files          33       34       +1     
  Lines        2117     2129      +12     
  Branches      303      303              
==========================================
+ Hits         1826     1838      +12     
  Misses        226      226              
  Partials       65       65
Impacted Files Coverage Δ
tests/test_repositories.py 100% <100%> (ø) ⬆️
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
piptools/scripts/compile.py 86.92% <100%> (-0.94%) ⬇️
piptools/pip.py 100% <100%> (ø)
tests/test_repository_local.py 100% <100%> (ø) ⬆️
tests/test_top_level_editable.py 100% <100%> (ø) ⬆️
tests/test_repository_pypi.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc0e10...ce413df. Read the comment docs.

blueyed
blueyed reviewed Feb 15, 2019
View reviewed changes
Comment thread tests/test_cli.py Outdated
@atugushev
atugushev force-pushed the help-default-index-url branch 3 times, most recently from 053caf1 to 082fabe Compare February 16, 2019 13:36
@vphilippon vphilippon modified the milestones: 3.4.0, 3.5.0 Feb 19, 2019
@atugushev
atugushev force-pushed the help-default-index-url branch from 082fabe to ce413df Compare February 28, 2019 01:19
@atugushev

atugushev commented Feb 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

I've resolved conflicts, rebased and squashed commits. I'll merge this as soon as tests are passed.

@blueyed as always, appreciate your feedback!

@atugushev
atugushev merged commit 1545aa7 into jazzband:master Feb 28, 2019
@atugushev atugushev added the enhancement Improvements to functionality label Mar 11, 2019
@atugushev

atugushev commented Mar 13, 2019

Copy link
Copy Markdown
Member Author

pip-tools v3.5.0 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blueyed blueyed blueyed approved these changes
@jdufresne jdufresne Awaiting requested review from jdufresne
@suutari suutari Awaiting requested review from suutari
@vphilippon vphilippon Awaiting requested review from vphilippon

Assignees

No one assigned

Labels

enhancement Improvements to functionality

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@atugushev @blueyed @vphilippon